[RISCV][LTO] Enable LTO #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[BOT] C-source lint diff for 5c08ac888793bbdf278494f0f973afe658081fe8 available here [BOT] C-source lint diff for af81f653b4f9d83d761413076dd423ce366f30e0 available here |
|
New effort has been made in upstream LLVM to parse the metadata in RISCV. D102582 does the necessary metadata parsing and D71387 then enables LTO. Discussion on the mailing list: https://lists.llvm.org/pipermail/llvm-dev/2021-July/151587.html |
Open
huettern
added a commit
that referenced
this pull request
Aug 11, 2021
* [LLVM] D72624 TargetMachine Hook for Module Metadata * [RISCV][LTO] enable LTO/ThinLTO on RISCV (D78035) * [LTO] Pass Module to TMFactory to correctly set-up ABI * [LLVM] disable assertion for in set options * [RISCV] LTO tests * [RISCV] gold/LTO mixed thin/regular test
pulp-bot
pushed a commit
that referenced
this pull request
Sep 4, 2021
* [LLVM] D72624 TargetMachine Hook for Module Metadata * [RISCV][LTO] enable LTO/ThinLTO on RISCV (D78035) * [LTO] Pass Module to TMFactory to correctly set-up ABI * [LLVM] disable assertion for in set options * [RISCV] LTO tests * [RISCV] gold/LTO mixed thin/regular test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the two patches https://reviews.llvm.org/D78035 and https://reviews.llvm.org/D72624 this PR aims at enabling LTO for RISCV.
Working
Not Working
The ELF emitted by
llvm-ltomisses the0x4, double-float ABIflags which causes the second link step (that links the code with the crt0 in my test case) to fail due to different ABI. This should be addressed by the two patches but does not seem to work for the emitted ELF. The intermediate steps during LTO do have the correct ABI parsed from the IR metadataFixed in 6e01505
ToDo
partially done in 6c529fc
elf32lriscvemulation