Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the link for the how to submit #670

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Changed the link for the how to submit #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/controllers/home_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ def about; end

def features; end

def submit; end

def policies; end

def contributors; end
Expand Down
48 changes: 0 additions & 48 deletions app/views/home/submit.html.erb
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion app/views/shared/_nav_links.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
<li class="nav-item"><a class="nav-link" href="<%= root_path %>">Home</a></li>
<li class="nav-item"><a class="nav-link" href="<%= home_about_path %>">About</a></li>
<li class="nav-item"><a class="nav-link" href="<%= home_features_path %>">Features</a></li>
<li class="nav-item"><a class="nav-link" href="<%= home_submit_path %>">How to Submit</a></li>
<li class="nav-item"><a class="nav-link" href="https://datacommons.princeton.edu/describe/" target="_blank">How to Submit</a></li>
</ul>
1 change: 0 additions & 1 deletion config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@

get 'about' => 'home#about', as: :home_about
get 'features' => 'home#features', as: :home_features
get 'submit' => 'home#submit', as: :home_submit
get 'policies' => 'home#policies', as: :home_policies
get 'contributors' => 'home#contributors', as: :home_contributors

Expand Down
5 changes: 0 additions & 5 deletions spec/requests/static_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,4 @@
get "/about"
expect(response).to have_http_status(:success)
end

it "has a how to submit page" do
get "/submit"
expect(response).to have_http_status(:success)
end
end
2 changes: 1 addition & 1 deletion spec/system/front_page_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
visit '/'
expect(page).to have_link "Home", href: "/"
expect(page).to have_link "About", href: "/about"
expect(page).to have_link "How to Submit", href: "/submit"
expect(page).to have_link "How to Submit", href: "https://datacommons.princeton.edu/describe/"
expect(page).to have_link "Accessibility", href: "https://accessibility.princeton.edu/help"
end
end
Expand Down