Error handling when indexing DataSpace datasets #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR undoes a commit that I did as part of this PR: https://github.com/pulibrary/pdc_discovery/pull/620/files
Catching the DataSpace exception has the unintended consequence of continuing the indexing process (which sounds like a good idea) but that results in a new index with no DataSpace records.
In this PR I am letting the exception flow (as it did before) which stops the indexing process and keeps the previous data in place. Not ideal but all in all a better outcome than blowing away the DataSpace records every time DataSpace is not available during the reindex process, which sadly is quite common.