Include 10 events in seeds of database

[lizgarciao]

closes #2268

[sandbergja]

Thanks, @lizgarciao !

[sandbergja]

I like the year interpolation!

[sandbergja]

It looks like there are some failing tests. I think because you are specifying ids here, the database doesn't think to increment the id sequence, so there are failures when it attempts to create a second row with the same ID (e.g. 1).

If you don't specify an id in this line, and just let the database keep track of assigning IDs, it should fix it.

[lizgarciao]

Thanks for the feedback, Jane. I removed the id, but there are three tests with Rspec that are failing. I think this is because the tests are creating events and checking that these records are saved in the ActiveRecord. However, the tests do not take into account that there already exist 10 events.

Here are the failures for convenience:

[christinach]

There are a couple of things that we need to do for this ticket:

• When we create an event we should also create a dump with a file and mark the event success: true. I'll review the relations in the code and update the logic that needs to be followed for the creation of these records in the seeds file.
• In the failing spec: 1. we can delete all the events (which will also delete the dumps etc that are connected to the specific event.) in a before do. However this would mean that someone would have to run the seeds file again in env: dev to see the events in the events page. 2. Or we could run this part of the seeds file only in env: dev so that we don't mess up with the test env. 3. Or we can review the specs and see how we can improve them.

[christinach]

👍🏻

[christinach]

do you still need these changes with your recent update in the seeds file?

[christinach]

Thanks @lizgarciao 😃