Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"computer network resources" are being misclassified as primary sources #2528

Closed
sandbergja opened this issue Oct 16, 2024 · 0 comments · Fixed by #2529
Closed

"computer network resources" are being misclassified as primary sources #2528

sandbergja opened this issue Oct 16, 2024 · 0 comments · Fixed by #2529
Assignees
@sandbergja
Labels
bug The application does not work as expected because of a defect unplanned work Tickets that were not part of the workcycle

Comments

@sandbergja
Copy link
Member

Expected behavior

"computer network resources" are not considered to be primary sources unless they have one of the primary source genres in the record.

Actual behavior

They are included -- I think because the word "resources" contains the word "sources". See MMS ID 99125445731306421 as an example.

Steps to replicate

  1. Go to https://catalog.princeton.edu/catalog?f%5Bgenre_facet%5D%5B%5D=Primary+source&search_field=all_fields&q=id%3A99125445731306421 -- this should be empty

Impact of this bug

Primary source genre facet is less reliable.
@sandbergja sandbergja added bug The application does not work as expected because of a defect unplanned work Tickets that were not part of the workcycle labels Oct 16, 2024
@sandbergja sandbergja self-assigned this Oct 16, 2024
sandbergja added a commit that referenced this issue Oct 16, 2024
@sandbergja
[#2528] Don't include genres in Primary Source facet if only part of …
cbfb4ab 
…the word matches

This fixes a bug in which a subdivision 'Computer network resources' matched
against the genre 'Sources', since the word 'resources' contains the word
'sources'.
@sandbergja sandbergja mentioned this issue Oct 16, 2024
Merged
christinach added a commit that referenced this issue Oct 16, 2024
@christinach
Merge pull request #2529 from pulibrary/primary-source-bug
14992e6 
[#2528] Don't include genres in Primary Source facet if only part of the word matches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandbergja sandbergja

Labels
bug The application does not work as expected because of a defect unplanned work Tickets that were not part of the workcycle
Projects
None yet
Milestone
No milestone
1 participant
@sandbergja