Reduce redux saveState overhead #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed my CPU was quite high when downloading big streams and most of the CPU was being spent doing browser.storage.local.set(...) for saving the state. This state only appears to be needed when the background page is reloaded (which will never happen if the a content-script is active. Buffering the save by 200ms reduces JS overhead by about ~40% (not including native methods overhead) and total CPU usage on my system (circa 2022 AMD 16 core) is reduced by ~28%.
|
Awesome work! I decided to use a "throttle" function. Wdyt? |
|
I didn't bench 100ms vs 200ms but I'm sure it's fine. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed my CPU was quite high when downloading big streams and most of the CPU was being spent doing browser.storage.local.set(...) for saving the state. This state only appears to be needed when the background page is reloaded (which will never happen if the a content-script is active.
Buffering the save by 200ms reduces JS overhead by about ~40% (not including native methods overhead) and total CPU usage on my system (circa 2022 AMD 16 core) is reduced by ~28%.
Attaching 10s profile captures before(unbuffered) and after (buffered):
hls-perf-traces.tar.gz