update: Additional drive action structuring and extraction #911
+354
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isTravis
commented
Jan 22, 2025
| @@ -158,6 +157,15 @@ export const run = defineRun<typeof action>( | |||
| relations, | |||
| }); | |||
| } | |||
| await updatePub({ | |||
There was a problem hiding this comment.
This is my first time using updatePub in an action (as opposed to just creating new related pubs). Am I missing anything obvious with how I setup the call?
There was a problem hiding this comment.
nope, looks good to me. that looks like the right value format and passing on the lastModifiedBy like you did is correct
kalilsn
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High-level Explanation of PR
This addresses many (all?) of the remaining migration changes needed to support GDrive editing.
Test Plan
I think I'll need to test this against our prod Arcadia community to get a real sense of whether anything is missing. (Would be great to be able to clone a prod community to dev at some point). But, I only touch Drive action files, so I don't think the surface area is too large if I did miss a bug somewhere.