chore: remove integration deployments #898
Merged
+401
−9,745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3mcd
force-pushed
the
em/rm-integrations
branch
from
cf7e167 to
a1c5175
Compare
tefkah
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
💯
only suggestion i'd have would be to also delete these two lines in blake
platform/infrastructure/terraform/environments/blake/main.tf
Lines 46 to 47 in bc6c85d
* remove integration code and tables * fix: add missing export * chore: remove legacy integration reference * chore: remove references to sdk package * Tfk/remove integrations code (#901) * fix: remove integration reference from dockerfile * fix: generate more up to date types * fix: remove integration files from db * fix: remove integration instances from test file * fix: remove integration fetching code * fix: remove ref to integrations in comment for tokens * fix: remove ref to integration in authentication readme * fix: remove ref to integrations in comment on api contracts * fix: remove integration exports from db * fix: remove integration table types from db package * fix: remove unecessary swagger file * chore: remove integrations ref from dev script --------- Co-authored-by: Thomas F. K. Jorna <[email protected]> --------- Co-authored-by: Thomas F. K. Jorna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ECS task definitions for our two legacy integrations. I also removed the integrations from our dockerfile and updated the monorepo lockfile.
Terraform plan (it's big, and only destructive changes): plan.txt