Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: pubs with no discussions #873

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Fix: pubs with no discussions #873

merged 3 commits into from
Dec 26, 2024

Conversation

gabestein
Copy link
Member

Issue(s) Resolved

Fixes three errors:

  1. Where we would send a bad query if a legacy pub had no discussions.
  2. Where we assumed a discussion always had a comment.author, but in cases with anonymous comments it has a comment.commenter.
  3. We were passing in an undefined ORCID url even if the user didn't have an ORCID

Test Plan

Discussions Issue

  • Import a pub with no discussions and make sure versions show up
  • Import a pub with discussions and make sure they show up
  • Repeat both and make sure both work as expected.

Comments and ORCID Issue

  • Import a pub with anonymous comment.commenter discussions.
  • Make sure it loads
  • Make sure any users with ORCIDs and avatars have them passed in

Screenshots (if applicable)

Notes

@gabestein gabestein requested a review from isTravis December 25, 2024 16:25
Copy link
Member

@isTravis isTravis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 I bumped into that commenter issue on some of the legacy processing earlier - I should've thought of that and mentioned it when we first saw this hiccup. Nice catch!

@gabestein gabestein merged commit 22f3c03 into main Dec 26, 2024
8 checks passed
@gabestein gabestein deleted the gs/fix-gdrive-action-issues branch December 26, 2024 13:14
@gabestein gabestein restored the gs/fix-gdrive-action-issues branch December 26, 2024 13:14
@gabestein gabestein deleted the gs/fix-gdrive-action-issues branch December 26, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants