Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use large GitHub runner #70

Merged
merged 2 commits into from
May 29, 2024
Merged

Use large GitHub runner #70

merged 2 commits into from
May 29, 2024

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented May 23, 2024

build(runner): use large GitHub runner

Use PubNub large GitHub runner.

@parfeon parfeon added priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: build This PR contains changes to the build system (like Travis or publishing a package). labels May 23, 2024
@parfeon parfeon self-assigned this May 23, 2024
@parfeon parfeon requested a review from marcin-cebo May 29, 2024 08:12

jobs:
check-release:
name: Check release required
runs-on: ubuntu-latest
if: ${{ github.event.pull_request.merged && endsWith(github.repository, '-private') != true }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before change runs-on was before if, now after. Is this intentional?

Copy link
Contributor Author

@parfeon parfeon May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcin-cebo this whole entry is a key-value object, so order actually doesn't matter, and I changed it just to see from the start when it will run and only after that 'where' :)

@parfeon parfeon merged commit 5c534e2 into master May 29, 2024
@parfeon parfeon deleted the build/change-gh-runner branch May 29, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: build This PR contains changes to the build system (like Travis or publishing a package).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants