Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to inject custom PNSDK source #232

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Add option to inject custom PNSDK source #232

merged 2 commits into from
Jan 20, 2025
+47 −13

Conversation

jakub-grzesiowski
Copy link
Contributor

No description provided.

mohitpubnub
mohitpubnub approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@mohitpubnub mohitpubnub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Api/PubnubApi/PNSDK/DotNetPNSDKSource.cs

namespace PubnubApi.PNSDK;

public class DotNetPNSDKSource : IPNSDKSource
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jakub-grzesiowski jakub-grzesiowski merged commit 69d3f0b into master Jan 20, 2025
5 checks passed
@jakub-grzesiowski jakub-grzesiowski deleted the pnsdk-fix branch January 20, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohitpubnub mohitpubnub mohitpubnub approved these changes

@Xavrax Xavrax Awaiting requested review from Xavrax Xavrax is a code owner

@marcin-cebo marcin-cebo Awaiting requested review from marcin-cebo marcin-cebo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakub-grzesiowski @mohitpubnub