-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: refactored events data parsing implementation #231
Conversation
…ion implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some serialization concerns, mostly due to Unity ion the case of NewtonsoftJsonDotNet
public class EventDeserializer | ||
{ | ||
private readonly IJsonPluggableLibrary jsonLibrary; | ||
private readonly NewtonsoftJsonDotNet newtonSoftJsonLibrary; // the default serializer of sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, now it LGTM!
@pubnub-release-bot release as v7.1.1.0 |
🚀 Release successfully completed 🚀 |
refactor(subscribe): event result data parsing implementation enhancement
Refactored event result data parsing logic within the subscribe feature for enhanced performance and maintainability.