Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: refactored events data parsing implementation #231

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Conversation

mohitpubnub
Copy link
Contributor

@mohitpubnub mohitpubnub commented Jan 13, 2025

refactor(subscribe): event result data parsing implementation enhancement

Refactored event result data parsing logic within the subscribe feature for enhanced performance and maintainability.

@mohitpubnub mohitpubnub self-assigned this Jan 13, 2025
@mohitpubnub mohitpubnub added the priority: medium This PR should be reviewed after all high priority PRs. label Jan 13, 2025
Copy link
Contributor

@jakub-grzesiowski jakub-grzesiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some serialization concerns, mostly due to Unity ion the case of NewtonsoftJsonDotNet

src/Api/PubnubApi/Builder/ResponseBuilder.cs Outdated Show resolved Hide resolved
public class EventDeserializer
{
private readonly IJsonPluggableLibrary jsonLibrary;
private readonly NewtonsoftJsonDotNet newtonSoftJsonLibrary; // the default serializer of sdk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

src/Api/PubnubApi/JsonDataParse/EventDeserializer.cs Outdated Show resolved Hide resolved
@mohitpubnub mohitpubnub added the type: refactor This PR contains refactored existing features. label Jan 15, 2025
Copy link
Contributor

@jakub-grzesiowski jakub-grzesiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, now it LGTM!

@mohitpubnub
Copy link
Contributor Author

@pubnub-release-bot release as v7.1.1.0

@mohitpubnub mohitpubnub merged commit c10b113 into master Jan 16, 2025
5 checks passed
@mohitpubnub mohitpubnub deleted the CLEN-2345 branch January 16, 2025 06:30
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium This PR should be reviewed after all high priority PRs. type: refactor This PR contains refactored existing features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants