Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlling the size of related sets listed on the left hand side #82

Closed
Sreyanth opened this issue Feb 18, 2015 · 9 comments
Closed

Controlling the size of related sets listed on the left hand side #82

Sreyanth opened this issue Feb 18, 2015 · 9 comments
Milestone

Comments

@Sreyanth
Copy link
Member

The sets listed on the left hand side (like in spectralworkbench.org/search/led) are causing the page to load slower and compelling the page to have a lot of white space in the bottom. The related sets could be confined only to some 5-8 with a button to explore more sets.

@jywarren
Copy link
Member

we could also show them in 2 tabs in the same column, like on the dashboard

On Wed, Feb 18, 2015 at 3:01 PM, Sreyanth [email protected] wrote:

The sets listed on the left hand side (like in
spectralworkbench.org/search/led) are causing the page to load slower and
compelling the page to have a lot of white space in the bottom. The related
sets could be confined only to some 5-8 with a button to explore more sets.


Reply to this email directly or view it on GitHub
#82.

@Sreyanth
Copy link
Member Author

Yes, but still we will have to load all the data on to the browser right? I used the developer tools in Chrome to see how much content spectralworkbench.org/search/led is loading, and it turns out to be more than 14.6 MB

I don't see the point of loading so much content when we still browse away to /sets/show/id anyways. I think we should some how optimize the page.

@jywarren
Copy link
Member

Oh yes, certainly we want to paginate the sets to save data transfer etc.
By putting it in a tab, we can also ajaxify the loading, so it doesn't load
at all unless you press that tab.

On Wed, Feb 18, 2015 at 3:21 PM, Sreyanth [email protected] wrote:

Yes, but still we will have to load all the data on to the browser right?
I used the developer tools in Chrome to see how much content
spectralworkbench.org/search/led is loading, and it turns out to be more
than 14.6 MB

I don't see the point of loading so much content when we still browse away
to /sets/show/id anyways. I think we should some how optimize the page.


Reply to this email directly or view it on GitHub
#82 (comment)
.

@Sreyanth
Copy link
Member Author

Right. We could also use the loaded data to be used to display the set instead of pointing to /sets/show/id right?

@jywarren
Copy link
Member

Yeah, maybe we start with optimizing the page itself, but an alternate
issue could be optimizing set list display by not having to load raw data
for each of the spectra in list display? There are other ways to represent
a set than to have the mini-graph.

On Wed, Feb 18, 2015 at 3:25 PM, Sreyanth [email protected] wrote:

Right. We could also use the loaded data to be used to display the set
instead of pointing to /sets/show/id right?


Reply to this email directly or view it on GitHub
#82 (comment)
.

@Sreyanth
Copy link
Member Author

Yeah. Exactly what I wanted to say! 😄

@jywarren
Copy link
Member

jywarren commented Mar 2, 2015

Somewhat fixed using pagination in acf2a07

still want to:

  • optimizing set list display by not having to load raw data for each of the spectra in list display
  • possibly ajaxify sets loading, move sets display into a tab

@jywarren
Copy link
Member

jywarren commented Mar 2, 2015

Oh, sorry, my fix was for profile page only. Now optimizing the search page; this may help w/ downtimes and hanging. that was an awful query.

jywarren added a commit that referenced this issue Mar 2, 2015
@jywarren jywarren modified the milestone: 2.0 launch Apr 1, 2015
@jywarren
Copy link
Member

jywarren commented Oct 9, 2015

Closing this as it's been revised in the 2.0 interface for spectrum display; we could revisit for front-page sets display if we like.

@jywarren jywarren closed this as completed Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants