Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test comment-maintainers: clean up comments index.html #6503

Closed
wants to merge 1 commit into from

Conversation

jywarren
Copy link
Member

to test out comment-maintainers

Re: #6501

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

to test out comment-maintainers
@jywarren jywarren requested a review from a team as a code owner October 20, 2019 11:37
@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
3 Messages
📖 @jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.
📖 #
Screenshots 📸 (click to expand)

6503-test_questions.png

6503-test_embeddable_grids.png

6503-test_signup.png

6503-test_viewing_the_settings_page.png

6503-test_tag_by_author_page.png

6503-test_wiki_page_with_inline_grids.png

6503-test_stats.png

6503-test_viewing_the_dashboard.png

6503-test_searching_an_item_from_the_homepage.png

6503-test_questions_shadow.png

6503-test_login_modal.png

6503-test_profile_page.png

6503-test_comments.png

6503-test_tags.png

6503-test_signup_modal.png

6503-test_wiki.png

6503-test_methods.png

6503-test_tag_page.png

6503-test_blog_page_with_location_modal.png

6503-test_tag_wildcard.png

6503-test_embeddable_thumbnail_grids.png

6503-test_front_page_with_navbar_search_autocomplete.png

6503-test_login.png

6503-test_viewing_the_dropdown_menu.png

6503-test_viewing_question_post.png

6503-test_mobile_displays.png

6503-test_simple-data-grapher_powertag.png

6503-test_front.png

6503-test_question_page.png

6503-test_tag_contributors_page.png

6503-test_blog.png

6503-test_people.png

6503-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@jywarren jywarren closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants