Fixed over 80 issues. Left with 10. #6488
Conversation
|
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
|
Oh wow, were these rubocop issues? And, could you drop a link to the original issue in here so we're all linked together? Thank you!!! |
| @@ -7,7 +7,7 @@ def assets; end | |||
| def promote_admin | |||
| @user = User.find params[:id] | |||
| unless @user.nil? | |||
| if logged_in_as(['admin']) | |||
| if logged_in_as(%w(admin)) | |||
There was a problem hiding this comment.
This is in the rubocop config, but I'm not sure about it -- actually ['admin'] seems more readable and common of a usage... what do you think? Could we adapt the config to use this simpler format? Thank you!!!!
|
Sorry, I don't have my laptop with me for the weekend, will send it on
Monday if that's OK?
Cheers
…On Sat, 19 Oct 2019, 10:41 am Jeffrey Warren, ***@***.***> wrote:
Oh wow, were these rubocop issues? And, could you drop a link to the
original issue in here so we're all linked together? Thank you!!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6488?email_source=notifications&email_token=AEZNMEUIRF6AZ5KTUISF2K3QPLB2PA5CNFSM4JCFZQEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXI4RY#issuecomment-544116295>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEZNMEWR7FY66PNZBB3MSXDQPLB2PANCNFSM4JCFZQEA>
.
|
|
Yeah, its totally okay @bbborisk. Thanks |
|
Ok, so here is the original issue link.
#6340
Yup, there were around 94 issues. or something like that. I fixed some
syntax stuff and aligned the code, but these few I can't figure out on my
own. Thanks a lot for the help and support, this is my first time really
contributing and getting into programming profession after learning on my
own, so it means a LOT
cheers
…On Sat, 19 Oct 2019 at 21:23, Cess ***@***.***> wrote:
Yeah, its totally okay @bbborisk <https://github.com/bbborisk>. Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6488?email_source=notifications&email_token=AEZNMEQBPL3BGPJXHXYOANLQPNNEXA5CNFSM4JCFZQEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX23TA#issuecomment-544189900>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEZNMEW6OHUDRH6T5NKFTPTQPNNEXANCNFSM4JCFZQEA>
.
|
|
@bbborisk, I will give them a try and push to your branch if I succeed thanks so much for fixing these 👍 |
|
Yeah, of course, thanks a bunch for working so hard :)
Cheers
…On Sat, 2 Nov 2019 at 14:01, Cess ***@***.***> wrote:
@bbborisk <https://github.com/bbborisk>, I will give it a try and push to
your branch if I succeed thanks so much for fixing these
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6488?email_source=notifications&email_token=AEZNMEWVLPXTBZCT72AAZRLQRV22NA5CNFSM4JCFZQEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC43MDQ#issuecomment-549041678>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEZNMEX3XKJ5XUJAEP3K45DQRV22NANCNFSM4JCFZQEA>
.
|
|
Please rebase |
|
As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it. |
Hello! OK, so I fixed a bunch, but have no idea how to fix these 10.
I don't know if it is acceptable, looking forward to feedback. This is an amazing opportunity for me to learn, so thank you very much!
cheers!