-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable UI Part for Browser Notification #6105
Conversation
Restarted Build |
@jywarren lets gets this merge. |
Looks awesome. Can you upload a gif, and would you mind adding this page to the auto-screenshot system tests so we can see that page too? Thank you!!! |
Yeah sure! Will do it. |
Adding this in system test screenshot as well. |
Added auto screenshot system test for the settings page. |
Restarting Build. |
Finally test passed. Can we merge this? @jywarren |
Awesome!!! Great work! |
This seems to be working for Let's open a new issue to track that! Also, I didn't seem to get |
Yeah! it is currently working for mentioned username, I will add it to all the rest cases. It won't be much work since I only have to add just one line of code in every case. Will add it today. Thanks |
Awesome. Great!
…On Thu, Aug 15, 2019 at 3:24 PM Naman Gupta ***@***.***> wrote:
Yeah! it is currently working for mentioned username, I will add it to all
the rest cases. It won't be much work since I only have to add just one
line of code in every case. Will add it today. Thanks
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#6105?email_source=notifications&email_token=AAAF6JZQYQVPQUZGLEBBOSTQEWUNDA5CNFSM4IJF5R42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4MYBKY#issuecomment-521765035>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J3IUK57RCVDU44OGWTQEWUNDANCNFSM4IJF5R4Q>
.
|
Closes #6039