Investigate why duplicate topic boxes are appearing on some profile pages

[ebarry]

Please describe the problem

Hello! I'd like to break out a small issue from #6097 for @CleverFool77 to consider.

I am noticing that some profile pages have the same topic boxes appearing more than once.

I most frequently see this on new contributor profile pages (that are often in fact spammers but that shouldn't matter), such as this one, where multiple topics are repeated multiple times:

https://publiclab.org/profile/kolkatanewsnstories

What did you expect to see that you didn't?

I expect to see each topic only once.

Please show us where to look

https://publiclab.org/profile/kolkatanewsnstories

What's your PublicLab.org username?

liz

Thank you!

[jywarren]

@CleverFool77 mentioned that this code is being driven here: https://github.com/publiclab/plots2/blob/d4d69ab4144d1457749ff215c53b63e167cc7142/app/views/tag/_profileCard.html.erb#L3 In theory, any use of `user.tags` shouldn't return duplicates. So we could try to solve this upstream in user.rb under `def tags` -- adding a `.distinct` or a `.uniq` to ensure distinct tag results: Weird, it already has a `.uniq` here, at the bottom: https://github.com/publiclab/plots2/blob/d4d69ab4144d1457749ff215c53b63e167cc7142/app/models/user.rb#L148-L159 Could it be that we need add another .distinct on line 148?

…

On Wed, Aug 28, 2019 at 4:29 PM Liz Barry ***@***.***> wrote: Please describe the problem Hello! I'd like to break out a small issue from #6097 <#6097> for @CleverFool77 <https://github.com/CleverFool77> to consider. I am noticing that some profile pages have the same topic boxes appearing more than once. I most frequently see this on new contributor profile pages (that are often in fact spammers but that shouldn't matter), such as this one, where multiple topics are repeated multiple times: https://publiclab.org/profile/kolkatanewsnstories [image: repeating topic-boxes] <https://user-images.githubusercontent.com/161439/63889699-80ddf380-c9af-11e9-8f28-0aee2a4aa646.gif> What did you expect to see that you didn't? I expect to see each topic only once. Please show us where to look https://publiclab.org/profile/kolkatanewsnstories What's your PublicLab.org username? liz Thank you! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6219?email_source=notifications&email_token=AAAF6JYWIQ2F3YM7AVM7G7TQG3NYVA5CNFSM4IRSOB42YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIA2FFA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J4V2UEQPWWVN6Y6PN3QG3NYVANCNFSM4IRSOB4Q> .

[jywarren]

I believe this is solved! See for example https://publiclab.org/profile/liz