Defaulting to the use of one DBMS #4896
Comments
grvsachdeva
added
enhancement
|
thanks everyone for the great input here! One last thing before we make a
final decision - does someone want to ask in the next weekly Check-In what
databases people use? Especially first-timers? It'd be great to have extra
confirmation - do most newcomers use mysql or sqlite?
…On Fri, Mar 1, 2019 at 6:57 AM Emmanuel Hayford ***@***.***> wrote:
I've been away from plots2 for a while. Coming back and following the
README I found it cumbersome to get up and running quickly because there
are traces of a number of database management systems in plots2. This makes
it hard to set up and have tests running smoothly.
It'd be nice to have one DBMS for all to avoid the configuration headache
encountered through this. I believe this will get new contributors up and
running quickly and encourage more contribution from people as I think the
current multi-db setup/config is a bit intimidating considering we like to
welcome first-time coders on board.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4896>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJwLIb--1cZwbxtXM84jWtEQ03ltYks5vSRVvgaJpZM4bY3P_>
.
|
|
Nice idea @jywarren. Also, many contributors faced issues while getting started with Mapknitter due to MySQL - publiclab/mapknitter#307. |
|
+1!
…On Fri, Mar 1, 2019 at 10:48 AM Gaurav Sachdeva ***@***.***> wrote:
Nice idea @jywarren <https://github.com/jywarren>. Also, many
contributors faced issues while getting started with Mapknitter due to
MySQL - publiclab/mapknitter#307
<publiclab/mapknitter#307>.
How about a poll? @siaw23 <https://github.com/siaw23> @jywarren
<https://github.com/jywarren>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4896 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_9R8-bIsKCS6d08jgyBOuyAKoZHks5vSUubgaJpZM4bY3P_>
.
|
|
Personally I find it unnecessary to create a poll. We use MySQL in production, so, if people vote SQLite, are we are going to switch from MySQL to SQLite? Or are we still going to keep SQLite and MySQL (still multiple DB problems here if people want SQLite). IMHO we should use the DB that we have in production locally for development (installing MySQL/MariaDB is fairly easy and there are lots of docs for newbies who'd get lost). I updated the README in my PR that shows how to get MariaDB running on Mac and Ubuntu. And by the way I think SQLite should be out completely because I think there has been some added raw SQL queries that won't work on SQLite. This raw SQL here among others is an example. |
|
I think we could ask just to know especially who we'd be asking to switch
over - and actually we could point them at your PR readme additions and ask
them to try going through the steps to see if there are any common
pitfalls? Mainly we just don't know currently if there are people using
sqlite, or if perhaps almost everyone uses mysql and we shouldn't be
worrying about it. Thanks!
…On Fri, Mar 1, 2019 at 11:31 AM Emmanuel Hayford ***@***.***> wrote:
Personally I find it unnecessary to create a poll. We use MySQL in
production, so, if people vote SQLite, are we are going to switch from
MySQL to SQLite? Or are we still going to keep SQLite and MySQL (still
multiple DB problems here if people want SQLite).
IMHO we should use the DB that we have in production locally for
development (installing MySQL/MariaDB is fairly easy and there are lots of
docs for newbies who'd get lost). I updated the README in my PR that shows
how to get MariaDB running on Mac and Ubuntu. And by the way I think SQLite
should be out completely because I think there has been some added raw SQL
queries that won't work on SQLite. This raw
<https://github.com/publiclab/plots2/blob/master/app/models/user.rb#L385>
SQL here among others is an example.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4896 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ3WRbkAniK0tbrRunv-BWgS7Tt38ks5vSVXMgaJpZM4bY3P_>
.
|
|
OK. Sounds good then. |
|
I think the poll is a good idea! But I agree 100% with @siaw23 that we should use the DB that we have in production locally for development. :) |
|
Just noting that @stefannibrasil and @sashadev-sky have also both voiced support for dropping sqlite -- here! #2712 (comment) |
|
I saw a poll app was installed by someone and approved it. @SidharthBansal any thoughts to add here? @cesswairimu ? |
|
@jywarren where's the poll? I did recommend for a poll app to be installed but didn't do the actual installation. Can you please create the poll for us Jeff? |
|
oh -- ok can you link me to the poll app? Sorry...
…On Tue, Mar 5, 2019 at 11:40 AM Emmanuel Hayford ***@***.***> wrote:
@jywarren <https://github.com/jywarren> where's the poll? I did recommend
for a poll app to be installed but didn't do the actual installation. Can
you please create the poll for us Jeff?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4896 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ0u_OtAbginStSQudHZ5Z3jfzQoYks5vTp3ggaJpZM4bY3P_>
.
|
|
@jywarren @siaw23 I think you might find that a lot of contributors have worked with sqlite and if they have worked with another DBMS with similar setup configurations as mysql, such as Postgres, that should be taken into consideration in the poll too. If you can set one up, conceptually the setup for the other one will make sense. (This was my own experience). Also, it would be good to create some setup instructions and send them to the people that poll that they have never used mysql. If they can follow the instructions and setup, we know we are good to go. I already have this going for macOS in another repo publiclab/mapknitter#355, still need people to test run that one. |
|
/polls MySQL MariaDB SQLite Other |
|
Oh, maybe it has to be the first item in the issue? |
|
Aha - ok, here it is: #4919 |
|
@jywarren I added a quick note about it under the check-in description towards the top so hopefully we'll get some more input. Can you see who is voting or is the poll anonymous? |
|
also if this issue becomes high priority and we're not sure how to move forward still I can work with @siaw23 (if you have the time too!) to try and make a complete report pinpointing causes of the issue, possible ways to fix it without getting rid of one DBMS, pros and cons, recommendations, etc. |
|
@gauravano I would like help any way I can to help here. |
|
your preference of db - #4919 |
I've been away from plots2 for a while. Coming back and following the README I found it cumbersome to get up to running quickly because there are traces of a number of database management systems in plots2. This makes it hard to set up and have tests running smoothly.
It'd be nice to have one DBMS for all to avoid the configuration headache encountered through this. I believe this will get new contributors up and running quickly and encourage more contribution from people as I think the current multi-db setup/config is a bit intimidating considering we like to welcome first-time coders on board.
I think once this is acceptable to everyone and we get to implement this, we can completely avoid #3840 where @milaaraujo correctly states:
Setup is the last thing we want to make hard for new contributors.
The text was updated successfully, but these errors were encountered: