Upgrade to Rails 4.2

[jywarren]

We're starting to get warnings for the paperclip gem:

DEPRECATION WARNING: [paperclip] [deprecation] Rails 3.2 and 4.1 are unsupported as of Rails 5 release. Please upgrade to Rails 4.2 before upgrading paperclip. (calle
d from <class:Image> at /home/warren/sites/plots2/app/models/image.rb:12)
DEPRECATION WARNING: [paperclip] [deprecation] Rails 3.2 and 4.1 are unsupported as of Rails 5 release. Please upgrade to Rails 4.2 before upgrading paperclip. (calle
d from <class:User> at /home/warren/sites/plots2/app/models/user.rb:21)

Worth trying it out in the Gemfile and Gemfile.lock and seeing how the tests do?

[mridulnagpal]

@jywarren I'd like to try it out

[jywarren]

I believe we've left some comments in the codebase as well, whenever we did a rails 4 or 3 specific fix so it may be worth searching for 'Rails 3' or 'Rails 4'!

…

On Dec 14, 2016 6:25 PM, "Mridul Nagpal" ***@***.***> wrote: @jywarren <https://github.com/jywarren> I'd like to try it out — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1102 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ4mC7Mj-_1ocor1y2YckJ-e0HTqyks5rIHrNgaJpZM4LNf-n> .

[mridulnagpal]

@jywarren So what all things will I have to do? I don't know where to start

[jywarren]

Yeah it's a tough one. I think for starters, change the gemfile and run 'bundle install' and then add the Gemfile.lock -- then create a PR. We'll see what happens.

I ran a search for "Rails 3" and "Rails 4" and didn't find anything. So I guess we see what happens?

It looks like the big one is from Rails 3-4, here: http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-3-2-to-rails-4-0

And then from 4.0-4.1 is not as bad, as can be expected. I'm not sure, but it looks like we'll want to go to 4.2!

[pycarlson]

@jywarren and @mridulnagpal I would like to help with this one. I've done an upgrade in the past so let me know if you want my help.

[mridulnagpal]

Yeah please do :)

…

On 20-Dec-2016 5:27 AM, "Paulette Luftig" ***@***.***> wrote: @jywarren <https://github.com/jywarren> and @mridulnagpal <https://github.com/mridulnagpal> I would like to help with this one. I've done an upgrade in the past so let me know if you want my help. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1102 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVULlFnRRI6MRZwbS_zH__gkaiyYoMGxks5rJxnhgaJpZM4LNf-n> .

[jywarren]

Merge into #1318 --