Add tests for big/small gifs (but not big, yet) (#5433)

* Add tests for big/small * test gif * small.gif * small gif * Add files via upload * Fix string/integer conversion on gif size comparison * Update images_controller_test.rb * add login first * Update images_controller_test.rb
publiclab · Apr 9, 2019 · 3ebb453 · 3ebb453
1 parent 05a2487
commit 3ebb453
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 2 deletions.
diff --git a/app/models/image.rb b/app/models/image.rb
@@ -25,7 +25,7 @@ def is_image?
   end
 
   def skip_large_gifs
-    ! (filetype == 'gif' && photo_file_size > 3.megabytes)
+    ! (filetype == 'gif' && photo_file_size.to_i > 3.megabytes)
   end
 
   def filetype

diff --git a/test/fixtures/small.gif b/test/fixtures/small.gif
diff --git a/test/functional/images_controller_test.rb b/test/functional/images_controller_test.rb
@@ -47,7 +47,35 @@ def setup
         }
     assert_equal 'application/json', @response.content_type
   end
-
+
+  test 'upload a small gif' do
+    user = UserSession.create(users(:jeff))
+    upload_photo = fixture_file_upload('small.gif', 'image/gif')
+    post :create,
+        params: {
+            image: {
+                photo: upload_photo,
+                title: 'Rails image',
+            },
+        }
+    assert_response :success
+  end
+
+# We'd like to do this but don't want to have to add a big gif to the repository... 
+# We need to synthesize a fake big gif locally? (it won't be processed anyways)
+#   test 'rejecting upload of a big gif' do
+#     user = UserSession.create(users(:jeff))
+#     upload_photo = fixture_file_upload('small.gif', 'image/gif')
+#     post :create,
+#         params: {
+#             image: {
+#                 photo: upload_photo,
+#                 title: 'Rails image',
+#             },
+#         }
+#     assert_response :failure
+#   end
+
   test 'creation via daturl' do
     user = UserSession.create(users(:jeff))
     data = "data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAYEBQYFBAYGBQYHBwYIChAKCgkJChQODwwQFxQYGBcUFhYaHSUfGhsjHBYWICwgIyYnKSopGR8tMC0oMCUoKSj/2wBDAQcHBwoIChMKChMoGhYaKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCj/wAARCAAQABADASIAAhEBAxEB/8QAFQABAQAAAAAAAAAAAAAAAAAAAAf/xAAUEAEAAAAAAAAAAAAAAAAAAAAA/8QAFQEBAQAAAAAAAAAAAAAAAAAABgj/xAAUEQEAAAAAAAAAAAAAAAAAAAAA/9oADAMBAAIRAxEAPwCdABykX//Z"