Restructure rake test task runner

[sashadev-sky]

references #345, #355

• tests pass -- rake test
• code has been rebased on top of latest master (check if another pull request was added recently, and please rebase)
• pull request is descriptively named and, if possible, multiple commits squashed if they're smaller changes

Thanks!

============
Updates made on top of mySQL5.7 PR updates (#355) I think that should be merged first anyway and then i'll just remove those from under this

Pending from chat with @jywarren in PR #355

• In a comment above each one, explain the command to run each task
• Include integration tests
• Integrate with Travis

Notes on Ruby Warnings (unrelated to mySQL update)

• Warning ::Fixnum is deprecated error: this warning will be fixed with an update to Rails 5. see here
• File.exists? (deprecated since ruby 2.2.0) updated to File.exist? comes from gems and from the source code for running a rake test. Source code is updated to File.exist? for Rails 4. Current recommendation: turn off warnings
• warning: loading in progress, circular require considered harmful also comes from gems. Current recommendation: turn off warnings.
• warning: method redefined; discarding old <method_name>: also comes from gems and comes from any existing gem methods that are redefined in config/initializers. Updates to gems should start to fix some of these.
• URI.escape obsolete error is in gems. Method is deprecated in favor of rail's to_param
• warning: instance variable @____ not initialized: there are a bunch of these. to fix, we need to remove all of the instance variables from partials. I think maybe we should open a separate issue for this
  • also /app/app/views/layouts/_footer.html.erb:1: warning: assigned but unused variable - footer this error comes up for every partial with its filename as the respective unused variable. Not sure why put that into separate issue along with above
• add lib/tasks/test_unit.rake file with rake task test runners for all functional and unit tests with the option to suppress warnings
  • Switching verbose to 'false' would create even less output but the tradeoff would be not being able to see the exact test file that is being run at each point in time
  • Under rake --tasks all tasks starting with the description "Autotask" are from this file

Problem causing gems
These gems throw the most warnings and the same warnings multiple times creating unreadable testing outputs. Maybe updates could fix this but it is also related to built in rails, active support, etc. settings so not sure. Would be good to open a separate issue for these.

• paperclip seems to cause the greatest number of errors including errors mentioned above
• openid (circular warnings)
• will_paginate
• friendly_id

============

[jywarren]

oh, is this required?

[sashadev-sky]

@jywarren macOS Mojave searches for this. It's configurations for mysql are a little different than any past system with macOS. It is not a file it's a sym link. Maybe @gauravano can double check that this doesn't effect any other users?

[sashadev-sky]

@jywarren sorry this is an issue for #355. Should I just remove all changes related to #355 out from under this? It was just a little easier for me to work with the same configs across branches but if it causes confusion it's not worth it.

[grvsachdeva]

Tried this PR locally, no issue due to this.

[jywarren]

Ah i see you copied in everything here! Great! @siaw23 i wanted to ask your opinion on this way of running the tests, with maintainability and standardization in mind. Sasha's done some great work here, and it should help a lot, but is there anything we can do to ensure that it follows best practices and will be readable by most Rails devs? Just checking as I know you've worked on a lot of other Rails systems.

[siaw23-retired]

Nice work btw @sashadev-sky!

[jywarren]

oh cool - did this last update start getting Travis to run it? Thanks!

…

On Tue, Mar 5, 2019 at 2:47 PM Sasha Boginsky ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/controllers/application_controller.rb <#380 (comment)>: > @@ -34,7 +34,7 @@ def require_login unless logged_in? path_info = request.env['PATH_INFO'] flash[:warning] = "You must be logged in to access this section" - redirect_to '/login?back_to=' + URI.encode(path_info) # halts request cycle + redirect_to '/login?back_to=' + URI.encode_www_form(path_info) # halts request cycle @siaw23 <https://github.com/siaw23> I got it from the docs http://ruby-doc.org/stdlib-2.4.4/libdoc/uri/rdoc/URI/Escape.html. They're both replacements for it, but in this use case I think your solution does makes more sense. Travis likes it too so I made the update! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#380 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ_4rb1QLdUO1w6rUmcx89lPbjQ1Tks5vTsm6gaJpZM4be_CU> .

[sashadev-sky]

@siaw23 Thanks for the advice! I updated the PR per your suggestions. Please note that #355 is the PR referencing mySQL, etc. upgrades. I branched this PR out from it to focus on rake test tasks. And that is what @jywarren was requesting additional input on. (See his comment above).

I still haven't integrated Travis will look into that next. Prior commits were for the mySQL branch.

[sashadev-sky]

@jywarren Ok so I got this running with Travis and I think it is ready for merge.

If you reference the Travis build from my PR and a build from a recent PR such as this one yesterday, you will see that the testing output is the same but on mine most of the warnings are gone and readability is a lot better.

Another thing to note is that the current tests run so that a summary of each testing folder is outputted before moving on to the next, runs unit... says 13 tests passed... runs functional... says 25 tests passed, while mine just provides a summary at the end (38 tests passed). This is really the only difference and I can update that if you would prefer the former.

Please let me know your thoughts and how you would like to proceed! Thanks

[jywarren]

Looks super. Thanks @sashadev-sky !!!