Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed menu width of layer menu #194

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

ananyaarun
Copy link
Member

@ananyaarun ananyaarun commented May 30, 2019

Fixes #186

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

lel1

Thanks!

@jywarren
Copy link
Member

Hi, this is nice!!! What if we also restyled the menu opening button as in page 9 of our new style guide? Thanks Ananya!!!

@ananyaarun
Copy link
Member Author

Sure @jywarren , I'll look at it. Thanks !!!

Copy link
Collaborator

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! Would you like to do the changes requested by @jywarren here or in a seperate PR ? Thanks !

@ananyaarun
Copy link
Member Author

Hey @sagarpreet-chadha I have created a new PR for the changes @jywarren asked for.
Thanks !!

@ananyaarun
Copy link
Member Author

@sagarpreet-chadha , I have resolved the conflicts here. Thanks !

@ananyaarun ananyaarun requested a review from jywarren June 5, 2019 11:45
@jywarren
Copy link
Member

jywarren commented Jun 6, 2019

Hi! Super!! Can you share a final screenshot? Thanks!

@sagarpreet-chadha
Copy link
Collaborator

Hey ! Great work ,
I am going ahead and merging this 😄 !

@sagarpreet-chadha sagarpreet-chadha merged commit 0214f0c into publiclab:master Jun 6, 2019
@ananyaarun
Copy link
Member Author

Hey @jywarren
here is the screen shot. I actually made the changes you asked in a seperate PR , so this one just increases the menu width :)

lel1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase layer menu width in layer select dropdown
3 participants