Added second spinner to make progress visible when modules are collapsed #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add manifest.json * cache static assets for offline use * update cache * add meta theme-color and change static files to be cache * cache the files on network request * caching on first run Signed-off-by: tech4GT <[email protected]> * add a button to clear cache * add styling to clear cache link
I've arranged the modules in alphabetical order.
|
@publiclab/is-reviewers please have a look. |
|
Agreed! Can you rebase it? Thank you!!! |
| @@ -347,10 +348,15 @@ function DefaultHtmlStepUi(_sequencer, options) { | |||
| function onDraw(step) { | |||
| $(step.ui.querySelector(".load")).show(); | |||
| $(step.ui.querySelector("img")).hide(); | |||
| if($(step.ui.querySelector(".toggle").innerHTML.className="fa fa-caret-down")){ | |||
| $(step.ui.querySelector(".load-spin")).show(); | |||
There was a problem hiding this comment.
I don't know if this is possible or even useful but can you implement it in such a way that when the primary spinner is on then the collapse spinner is not shown?
|
Closing this , I made mistake by rebasing 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #657
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/is-reviewersfor help, in a comment belowThanks!