-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for all remaining modules in Modules.md and added a link in info.json for every Module. #555
Conversation
… info.json of each Module
@tech4GT please review. |
@Divy123 can you please change the position of already existing module docs so that they are in alphabetical order too. |
You can also add an index at the top of the page if you want to. |
I don't think that's required... |
That is some great work @Divy123 ! 🎉 |
Ok |
But how about an index ? |
Cool! I am adding the index at the top of Modules.md file. |
@Divy123, you can just add link like E.G: #link-to-module is just the heading given to the module like Blend Module (blend) => #blend-module-blend |
@harshkhandeparkar it works as required now. Sorry for two extra commits as I was doing some task and forgot to do some changes. Please review. |
Awesome work ! |
And the two commits are not a problem the pr is merged as a single commit. |
Thanks @harshkhandeparkar . |
@Divy123 Can you please sum up the stuff you pulled off here? That would be great since I see a lot of changes. |
@tech4GT I have changed/updated Modules.md file by adding the documentation of all remaining modules. |
Great!! Divy if you have spell checked we can go ahead and merge here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Divy can you also please run grunt build
and commit the dist files. Do make sure to pull the latest code from main branch before doing it though. :)
@tech4GT please have a look. I have made the necessary changes. |
Oh I should have squashed your commits! My bad 😅 |
… info.json of each Module
Fixes #506
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!