Added insert step button at every step #545
Conversation
|
@publiclab/reviewers please review. |
Bumps [cached-path-relative](https://github.com/ashaffer/cached-path-relative) from 1.0.1 to 1.0.2. **This update includes security fixes.** - [Release notes](https://github.com/ashaffer/cached-path-relative/releases) - [Changelog](https://github.com/ashaffer/cached-path-relative/blob/master/History.md) - [Commits](https://github.com/ashaffer/cached-path-relative/commits) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 3.3.7 to 3.4.0. **This update includes security fixes.** - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](twbs/bootstrap@v3.3.7...v3.4.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [buffer](https://github.com/feross/buffer) from 5.0.8 to 5.2.1. - [Release notes](https://github.com/feross/buffer/releases) - [Commits](feross/buffer@v5.0.8...v5.2.1) Signed-off-by: dependabot[bot] <[email protected]>
|
@Divy123 please provide a gif/screenshot for the PR. |
|
Also you should probably change the arrow functions to normal ones as it is not supported by all browsers |
|
Also you can add a fontawesome icon to the btn if you want. |
|
@Divy123 Were you able to figure out the correct index to run the sequence from? |
|
@tech4GT actually I tried to run it from the current index and some other related values but then I realized that run was only responsible for producing output and the UI that was being added was due to insertSteps() which inserted it correctly in the steps array so I reloaded the page after every insert step which correctly displays all steps in correct order. Hope that is correct. |
|
Hmm, I think we should not have to reload the page for it to work, hold on I'll take a look. |
|
Sure @tech4GT please take a look. |
|
Okay Divy, I am getting a couple of errors here, I think Image not loading is because of some errors in defaultStepUI file, which is preventing the javascript on the page to run any further. Let me fix this up a little. Thanks. |
|
@jywarren Can you help out a little here, I am trying to isolate the code which appends the step in the div, while adding steps and which removes the step from the html when we we remove a step. |
Signed-off-by: tech4GT <[email protected]>
ghost
assigned
|
@Divy123 Pull these changes and try it out, I think this should work now! 😄 |
|
@tech4GT yes its working perfectly. Thanks a lot 😄 . The Travis is failing at one test for node v6 at npm install. Can you please guide on that? |
|
Divy try opening and closing the pull request. |
|
@tech4GT all tests passed. I think it is ready now. Thanks a lot for your help 😄 . |
|
Divy, I think this needs a bit more work, I don't think this is working correctly for sequences and I noticed that saving sequences is also not working out correctly. I'll push the fixes in and then we can merge. |
Signed-off-by: tech4GT <[email protected]>
Signed-off-by: tech4GT <[email protected]>
Signed-off-by: tech4GT <[email protected]>
|
@Divy123 I think we can do one more thing here, disable the add button for the last step, can you do that? Thanks. |
|
And sorry to pile in all this work in this pull request, Actually I have not really been coding a lot on this project lately and I saw some small errors here and there so I fixed them. |
|
Sure @tech4GT . I am upon it and thanks for your help. |
|
@tech4GT please have a look. |
|
Great! I think we are good to go here! 🎉 |
|
Thanks @tech4GT . |
|
Fantastic! |
Fixes #466
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!