Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse step on click #534

Closed
wants to merge 5 commits into from
Closed

Conversation

kevinzluo
Copy link

@kevinzluo kevinzluo commented Dec 6, 2018

Fixes #498

Collapses step on click. Its 2 AM over here and I don't think I have any more brain power left to test this 😞 . From what I have tried, it seems to work appropriately:

**OLD:
Image from Gyazo

Image from Gyazo

I still want to add a few changes, namely that each section opens on hover and the caret actualy changes to the correct orientation on hover instead of click. **EDIT: I actually implemented this and it doesn't feel very useful, so I ended up removing it

NEW:
collapsesteps

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@kevinzluo
Copy link
Author

@publiclab/reviewers
Mind taking a look?

@tech4GT
Copy link
Member

tech4GT commented Dec 9, 2018

Hey @kevinzluo Great work!! I'll try this out in my browser right now!! 😄

@tech4GT
Copy link
Member

tech4GT commented Dec 9, 2018

There seems to be some issue with this
screen shot 2018-12-09 at 2 07 41 pm

@kevinzluo
Copy link
Author

Whoops! I'll try to fix it as soon as I can.

@kevinzluo
Copy link
Author

@tech4GT Sorry for the late response. I have been preoccupied elsewhere. Could you let me know how to reproduce the error? I couldn't seem to create it on my system.

Copy link
Member

@tech4GT tech4GT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kevinzluo Actually I tried this in my browser and it did not work, as in clicking on the collapse button did not work in the first try, the text came into focus like in my screenshot but the step did not collapse.

@tech4GT
Copy link
Member

tech4GT commented Dec 19, 2018

PS Sorry for the late response from me too! 😅

@jywarren
Copy link
Member

jywarren commented Jan 3, 2019

Oh goodness, sorry @aashna27 for the duplication here... but perhaps you could help debug and finish this one off? Thank you so much!!!

@jywarren
Copy link
Member

jywarren commented Jan 3, 2019

This looks so cool!!!

@jywarren
Copy link
Member

jywarren commented Jan 8, 2019

Are folks stuck here? Need any help? Thanks a lot!

@kevinzluo
Copy link
Author

kevinzluo commented Jan 8, 2019 via email

@aashna27
Copy link

aashna27 commented Jan 8, 2019

I would take it up.

@jywarren
Copy link
Member

Thanks! Solved in another PR!

@jywarren jywarren closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants