-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse step on click #534
Conversation
@publiclab/reviewers |
Hey @kevinzluo Great work!! I'll try this out in my browser right now!! 😄 |
Whoops! I'll try to fix it as soon as I can. |
@tech4GT Sorry for the late response. I have been preoccupied elsewhere. Could you let me know how to reproduce the error? I couldn't seem to create it on my system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kevinzluo Actually I tried this in my browser and it did not work, as in clicking on the collapse button did not work in the first try, the text came into focus like in my screenshot but the step did not collapse.
PS Sorry for the late response from me too! 😅 |
Oh goodness, sorry @aashna27 for the duplication here... but perhaps you could help debug and finish this one off? Thank you so much!!! |
This looks so cool!!! |
Are folks stuck here? Need any help? Thanks a lot! |
Hi. School has started back up for me so I really don't have time to work
on this. If anyone else would like to take over, feel free. So sorry about
this.
Kevin Luo
…On Mon, Jan 7, 2019 at 11:16 PM Jeffrey Warren ***@***.***> wrote:
Are folks stuck here? Need any help? Thanks a lot!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#534 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AqQaI66pLSnJWs-rxwGrK9ezM9l5JCKdks5vBCmXgaJpZM4ZGBdy>
.
|
I would take it up. |
Thanks! Solved in another PR! |
Fixes #498
Collapses step on click. Its 2 AM over here and I don't think I have any more brain power left to test this 😞 . From what I have tried, it seems to work appropriately:
**OLD:
I still want to add a few changes, namely that each section opens on hover and the caret actualy changes to the correct orientation on hover instead of click. **EDIT: I actually implemented this and it doesn't feel very useful, so I ended up removing it
NEW:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!