getNeighborPixel(x, y) method for Dynamic module #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tech4GT <[email protected]>
Signed-off-by: tech4GT <[email protected]>
Signed-off-by: tech4GT <[email protected]>
Signed-off-by: tech4GT <[email protected]>
jywarren
reviewed
Mar 30, 2018
src/modules/Dynamic/Module.js
Outdated
|
|
||
|
|
||
| /* Functions to get the neighbouring pixel by position (x,y) */ | ||
| var getNeighbourPixel = function(pixels,curX,curY,distX,distY){ |
There was a problem hiding this comment.
Hmm, yes, this does seem a bit more natural! You can also define this as function getNeighborPixel(...) which helps when debugging (the function name shows up rather than a singleton function assigned to a variable). If this looks good, can we tidy up lines 38-43 and we'll be ready to merge it in? Thanks!!!
Signed-off-by: tech4GT <[email protected]>
|
@jywarren done.! 😁 |
|
OK, looks good -- but is this out of date with base branch? Then ready to go! :-) 👍 👍 👍 |
…into dynamicFixAsFun
|
@jywarren synced😁 |
jywarren
changed the title
|
Fantastic!! 🎉 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jywarren check this out, done with getNeighbourPixel as function and getNeighborPixel as alias
replaces #204