Bump to v3.7.0 (trouble with pangocairo lib)

[jywarren]

https://github.blog/2021-09-01-improving-git-protocol-security-github/

This has already been done and released on the stable branch as v3.6.1 but we're doing it here too and completing #1751 to release v3.7.0.

We are stuck on running npm install due to pangocairo dependency. But we're working through this list of checkboxes:

#1751 (comment)

---

Release notes

Added

• New Shadow Module: Add shadows (borders) to images in bulk! New Shadow module #1507 by @niravasher
• New Alpha masking module: Alpha masking module #1546 by @blurry-x-face
• New sharpness module in Module for sharpening images #1612 by @waridrox

Fixed

• Percentage Parsing: Percentage values passed to the sequencer are now parsed more consistently. (Parse floating-point value from percentages #1733)
• Safari Fix: Image Sequencer will now work in the Safari browser! (Upgrade picomatch so image-sequencer works in Safari #1740)
• offline caching improvements in Offline caching: Try To fetch latest data first then shift to cached one. #1819 and -fixed registration problem of service worker #1807 by @vivek-30
• variety of other bugfixes!
• fixed Module selector console error Fixes Module Selector Console Error #1543 by @ss62171

Changed

• switch to GitHub Actions in try moving to Github Actions from Travis for CI #1783 (team effort!)
• switch to expr-eval in switch to expr-eval for dynamic module #1729 by @jywarren
• CLI improvements in refactor cli code #1785 by @blurry-x-face
• dependencies updated

[gitpod-io]

[jywarren]

Can't seem to run npm install and it's due to a Jan 19 2021 (year ago) pinning of canvas to v2.6.1 which isn't working. I'm wondering how #1778 resulted in canvas getting called out at that specific version?

0d7ab2b#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deR2048-R2056

@harshkhandeparkar i hope you're well, can you see how this happened and if we could figure out how to revert that part of it? I can't see how lint-staged has anything to do with canvas to be honest. Looking deeper.

[jywarren]

I'll try running yarn install instead.

[jywarren]

yarn install yields:

error [email protected]: The engine "node" is incompatible with this module. Expected version "0.8.x". Got "16.13.0"
error Found incompatible module.

[jywarren]

https://www.npmjs.com/package/canvas offers 2.8.0 - let's try that.

[jywarren]

ok pinning canvas in package.json to 2.8.0. But i see:

npm ERR! Package pangocairo was not found in the pkg-config search path.
npm ERR! Perhaps you should add the directory containing `pangocairo.pc'
npm ERR! to the PKG_CONFIG_PATH environment variable
npm ERR! No package 'pangocairo' found
npm ERR! gyp: Call to 'pkg-config pangocairo --libs' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
npm ERR! gyp ERR! configure error 
npm ERR! gyp ERR! stack Error: `gyp` failed with exit code: 1

Will look at recent docs of canvas to see if linux deps have changed for compiling it.

[jywarren]

Added these for canvas compiling prereqs:

sudo apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev

[jywarren]

#5 7.888 E: Unable to locate package libpango-1.0-dev
#5 7.888 E: Couldn't find any package by glob 'libpango-1.0-dev'
#5 7.888 E: Couldn't find any package by regex 'libpango-1.0-dev'

[jywarren]

npm ERR! Package pangocairo was not found in the pkg-config search path.
npm ERR! Perhaps you should add the directory containing `pangocairo.pc'
npm ERR! to the PKG_CONFIG_PATH environment variable
npm ERR! No package 'pangocairo' found

Leads to an intermittent issue at iterative/cml#723 and one using libpango1.0-dev in iterative/setup-cml#48 ...

Same in https://askubuntu.com/questions/1277279/pangocairo-header-files-not-installed - i'll try that - libpango1.0-dev instead of libpango-1.0-dev

[jywarren]

Hmm, E: Couldn't find any package by glob 'libpango1.0-dev'

[jywarren]

OK it's saying here to update node: https://stackoverflow.com/questions/27781097/error-when-installing-node-canvas-on-debian

[jywarren]

but i'm on v16??

[jywarren]

Hmm:

gitpod /workspace/image-sequencer $ apt search libpango
Sorting... Done
Full Text Search... Done
libpango-1.0-0/now 1.44.7-2ubuntu4 amd64 [installed,local]
  Layout and rendering of internationalized text

libpangocairo-1.0-0/now 1.44.7-2ubuntu4 amd64 [installed,local]
  Layout and rendering of internationalized text

libpangoft2-1.0-0/now 1.44.7-2ubuntu4 amd64 [installed,local]
  Layout and rendering of internationalized text

[jywarren]

Hmm. Let's maybe try compiling it on a local instead of GitPod. If it works, we can note that the gitpod env doesn't support canvas bc of the pangocairo issue.

[jywarren]

Now running npm install on my ARM chromebook.

[jywarren]

I can try on an x86 Debian machine next if it fails.

[jywarren]

Hmm, different error but still canvas:

npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file sh
npm ERR! errno ENOENT
npm ERR! [email protected] install: `node-pre-gyp install --fallback-to-build`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/warren/.npm/_logs/2022-01-14T20_43_11_250Z-debug.log

[jywarren]

Got stuck on chromebook, now trying on x86 debian

[jywarren]

OK! I was able to build it in node v16 on x86 debian!

[jywarren]

will try in gitpod on node v16 in case that was the issue.

[jywarren]

I think it wasn't the issue - because i see gitpod is on node v16 already. So, let's just bear in mind that there may be some issues compiling node canvas on some platforms. Oddly Gitpod is x86_64 which is probably identical to the machine i did this on. I'm not sure the issue to be honest, i'm curious if other folks are having trouble installing canvas in recent versions of this lib?

[jywarren]

Published as v3.7.0!!

[jywarren]

Noting unfortunately we had not compiled /dist/ at the time of publication, so to bring these features to pre-compiled in-browser use I am planning a 3.7.1 patch release in #1751

[jywarren]

Can't seem to run npm install and it's due to a Jan 19 2021 (year ago) pinning of canvas to v2.6.1 which isn't working. I'm wondering how #1778 resulted in canvas getting called out at that specific version?

Update: today, running the main branch in gitpod (after deleting yarn.lock, although possibly unrelated) i am able to run npm install now. node version 16.3.0, probably same as yesterday... strange but OK