Edge Detect Horizontal Edges Got Fixed

[harshkhandeparkar]

Fixes #1632 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[gitpod-io]

[harshkhandeparkar]

Failing travis looks promising.

[harshkhandeparkar]

One of the angle boundaries was weird. When the angle goes to pi it changes to -pi (our trigonometry is awesome). Because of the this, the second E-W boundary is angle > higher value || angle < lower value instead of lower value < angle < higher value

[harshkhandeparkar]

It looks slightly smoother now but I'm not sure whether it has been completely rectified.

[rishabhshuklax]

It looks slightly better than before, but lower right corner is still glitching

[harshkhandeparkar]

The lower right corner has a different color, I don't it is glitching, what is really glitching are the THICK vertical edges.

[harshkhandeparkar]

Ty for the img :)

[harshkhandeparkar]

Finally after almost a year!

[harshkhandeparkar]

@jywarren @blurry-x-face @publiclab/is-reviewers !

[rishabhshuklax]

Wow this looks so much better now!! 🎉

[jywarren]

Great work @harshkhandeparkar !!! 🎉 and great persistence!

I'm going to try it in GitPod!!

[jywarren]

Hmm, what's going on with the test, @harshkhandeparkar ?

Is this the right output? It seems to work!

Here's the QR code:

[jywarren]

@harshkhandeparkar can you take a look at the tests to see what's going wrong?

[jywarren]

Looks like, could it be due to syntax errors, or some ES6 issue? In module.js:

  lineNumber: 67,
  description: 'Unexpected token =>',
  index: 2050 }

[jywarren]

Perhaps it just needs to be rebased?

[harshkhandeparkar]

The test hasn't been updated to work with the new changes.

[jywarren]

Ah ok! No rush then. Thanks, @harshkhandeparkar !!!

[harshkhandeparkar]

@jywarren Finally pushed the new test.

[gitpod-io]

[codecov]

Codecov Report

Merging #1696 into main will increase coverage by 10.31%.
The diff coverage is 64.31%.

@@             Coverage Diff             @@
##             main    #1696       +/-   ##
===========================================
+ Coverage   55.11%   65.43%   +10.31%     
===========================================
  Files         117      133       +16     
  Lines        2344     2743      +399     
  Branches      360      439       +79     
===========================================
+ Hits         1292     1795      +503     
+ Misses       1052      948      -104     

Impacted Files	Coverage Δ
examples/lib/scopeQuery.js	18.51% <ø> (ø)
src/Modules.js	100.00% <ø> (ø)
src/modules/WebglDistort/Module.js	2.29% <0.00%> (ø)
src/ui/SetInputStep.js	12.90% <0.00%> (-1.39%)	⬇️
src/modules/ColorHalftone/Module.js	3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js	11.35% <4.08%> (-0.85%)	⬇️
examples/lib/intermediateHtmlStepUi.js	11.11% <5.55%> (+0.94%)	⬆️
examples/lib/insertPreview.js	13.15% <20.00%> (-0.36%)	⬇️
src/util/getImageDimensions.js	20.00% <20.00%> (ø)
src/util/isGif.js	20.00% <20.00%> (ø)
... and 102 more

[harshkhandeparkar]

@publiclab/is-module-maintainers Tests Passing! 🎉

[jywarren]

Hooray!

[harshkhandeparkar]

I think this should be merged now, for v3.6.0

[jywarren]

Congrats!!