Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color halftone and module test #1678

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Jul 5, 2020

Screen Shot 2020-07-05 at 4 34 18 PM

Some really nice color halftoning effects: http://evanw.github.io/glfx.js/docs/#colorHalftone

color-halftone

Original:

external-content duckduckgo-1

@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #1678 into main will decrease coverage by 1.25%.
The diff coverage is 5.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
- Coverage   66.67%   65.42%   -1.26%     
==========================================
  Files         130      132       +2     
  Lines        2686     2742      +56     
  Branches      433      438       +5     
==========================================
+ Hits         1791     1794       +3     
- Misses        895      948      +53     
Impacted Files Coverage Δ
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)

@jywarren jywarren merged commit 1926c01 into publiclab:main Jul 5, 2020
@jywarren
Copy link
Member Author

jywarren commented Jul 5, 2020

@harshithpabbati @harshkhandeparkar would you be able to rebuild the stable branch so I can release a new version and get the demo updated? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant