-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blob analysis to work in node #1589
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1589 +/- ##
==========================================
- Coverage 66.67% 65.29% -1.39%
==========================================
Files 130 132 +2
Lines 2686 2746 +60
Branches 433 439 +6
==========================================
+ Hits 1791 1793 +2
- Misses 895 953 +58
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
This one's ready, just needs a review. |
Whew, excellent! And many thanks! Apologies for the slowness, just getting this going again! |
Fixes #1378
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!