Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorbar module default overlay shift fixed #1542

Merged

Conversation

akshaygupta533
Copy link

@akshaygupta533 akshaygupta533 commented Jan 19, 2020

Partially adresses #1538 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@welcome
Copy link

welcome bot commented Jan 19, 2020

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #1542 into main will increase coverage by 10.29%.
The diff coverage is 63.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1542       +/-   ##
===========================================
+ Coverage   55.11%   65.41%   +10.29%     
===========================================
  Files         117      132       +15     
  Lines        2344     2741      +397     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1793      +501     
+ Misses       1052      948      -104     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) ⬇️
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) ⬇️
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) ⬆️
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) ⬇️
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 100 more

@harshkhandeparkar
Copy link
Member

The test for the color bar module is not passing actually. But since this is an FTO, you don't have to fix it. We'll fix it in a followup.

@root00198
Copy link
Member

@harshkhandeparkar A lot of modules are failing, because of #1533...Please look into it.

@harshkhandeparkar
Copy link
Member

Let's discuss this under the same PR

@jywarren
Copy link
Member

Solution was just merged for the issue, can you rebase this to try it out? Thank you!

@akshaygupta533
Copy link
Author

@harshkhandeparkar Travis build is failing. How can I fix this?

@harshkhandeparkar
Copy link
Member

Weird. Only node 10 is failing. Try pushing a commit that doesn't change anything (like add a space or something). This will trigger the Travis build again. Let's see if it passes.

@akshaygupta533
Copy link
Author

Passed now! I don't know why it failed earlier. Can this be merged now?

@gitpod-io
Copy link

gitpod-io bot commented Jul 8, 2020

@harshkhandeparkar harshkhandeparkar requested a review from a team as a code owner October 15, 2020 19:48
@harshkhandeparkar harshkhandeparkar merged commit 1713751 into publiclab:main Oct 16, 2020
@welcome
Copy link

welcome bot commented Oct 16, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two. Please test out your work on this testing server and report back with a comment that all has gone well!
In the meantime, can you tell us your Twitter handle so we can thank you properly also do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Please find the link pinned in the issue section
Now that you've completed this, you can help someone else take their first step! Try looking at this list of first-timers-only issues, and see if someone else is waiting for feedback, or even stuck! 😕
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉
See: Public Lab's coding community!

@harshkhandeparkar
Copy link
Member

Thank you!

@jywarren
Copy link
Member

Thanks! Awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants