-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorbar module default overlay shift fixed #1542
Colorbar module default overlay shift fixed #1542
Conversation
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1542 +/- ##
===========================================
+ Coverage 55.11% 65.41% +10.29%
===========================================
Files 117 132 +15
Lines 2344 2741 +397
Branches 360 438 +78
===========================================
+ Hits 1292 1793 +501
+ Misses 1052 948 -104
|
The test for the color bar module is not passing actually. But since this is an FTO, you don't have to fix it. We'll fix it in a followup. |
@harshkhandeparkar A lot of modules are failing, because of #1533...Please look into it. |
Let's discuss this under the same PR |
Solution was just merged for the issue, can you rebase this to try it out? Thank you! |
4a2552f
to
9883801
Compare
@harshkhandeparkar Travis build is failing. How can I fix this? |
Weird. Only node 10 is failing. Try pushing a commit that doesn't change anything (like add a space or something). This will trigger the Travis build again. Let's see if it passes. |
Passed now! I don't know why it failed earlier. Can this be merged now? |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Thank you! |
Thanks! Awesome!! |
Partially adresses #1538 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!