Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Learn More Leads to the README #1539

Merged
merged 2 commits into from
Jan 21, 2020
Merged

UI Learn More Leads to the README #1539

merged 2 commits into from
Jan 21, 2020

Conversation

arghac14
Copy link
Member

@arghac14 arghac14 commented Jan 19, 2020

Fixes #1528 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@welcome
Copy link

welcome bot commented Jan 19, 2020

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #1539 into main will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #1539      +/-   ##
=========================================
+ Coverage   66.79%   66.8%   +0.01%     
=========================================
  Files         129     129              
  Lines        2671    2672       +1     
  Branches      430     430              
=========================================
+ Hits         1784    1785       +1     
  Misses        887     887
Impacted Files Coverage Δ
src/modules/PaintBucket/PaintBucket.js 100% <100%> (ø) ⬆️

@arghac14
Copy link
Member Author

arghac14 commented Jan 19, 2020

I have fixed the issue #1528
GIF

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 19, 2020

Please write the issue number in the PR body
Fixes #0000 (<=== Replace 0000 with the Issue Number)

@arghac14 arghac14 changed the title Fixed issue #1528: UI Learn More Link Should Lead to the README Fixes #1528: UI Learn More Link Should Lead to the README Jan 19, 2020
@arghac14
Copy link
Member Author

@harshkhandeparkar Issue number is written in the PR body. Please merge the PR.

@harshkhandeparkar
Copy link
Member

You just changed the PR title, not the PR body. PR body is where the PR description is written. If you write fixes #1528 in the PR body, it will automatically close the Github issue #1528 upon the merging of the PR.

@harshkhandeparkar harshkhandeparkar changed the title Fixes #1528: UI Learn More Link Should Lead to the README UI Learn More Leads to the README Jan 19, 2020
@harshkhandeparkar
Copy link
Member

@publiclab/is-reviewers

@arghac14
Copy link
Member Author

@harshkhandeparkar looks alright now I guess
.

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for your contribution!

@harshkhandeparkar
Copy link
Member

Please merge the PR

Sorry but I am just a reviewer here, not a maintainer. I cannot merge your PR.

@arghac14
Copy link
Member Author

@harshkhandeparkar okay no worries :) waiting for the maintainers to check this. Thanks for your help.

Copy link
Member

@debck debck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jywarren jywarren merged commit 7c63bb5 into publiclab:main Jan 21, 2020
@welcome
Copy link

welcome bot commented Jan 21, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Learn More Link Should Lead to the README
4 participants