-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Learn More Leads to the README #1539
Conversation
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1539 +/- ##
=========================================
+ Coverage 66.79% 66.8% +0.01%
=========================================
Files 129 129
Lines 2671 2672 +1
Branches 430 430
=========================================
+ Hits 1784 1785 +1
Misses 887 887
|
Please write the issue number in the PR body |
@harshkhandeparkar Issue number is written in the PR body. Please merge the PR. |
You just changed the PR title, not the PR body. PR body is where the PR description is written. If you write |
@publiclab/is-reviewers |
@harshkhandeparkar looks alright now I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for your contribution!
Sorry but I am just a reviewer here, not a maintainer. I cannot merge your PR. |
@harshkhandeparkar okay no worries :) waiting for the maintainers to check this. Thanks for your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Congrats on merging your first pull request! 🙌🎉⚡️ |
Awesome! Thanks! |
Fixes #1528 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!