Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aspect ratio module #1454

Merged
merged 17 commits into from
Jan 16, 2020
Merged

Added aspect ratio module #1454

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
56654b1
Base file
root00198 Jan 11, 2020
4402b42
Added aspect ratio module
root00198 Jan 11, 2020
98f4c16
Merge branch 'main' into aspect-ratio
harshkhandeparkar Jan 11, 2020
25bb146
Merge branch 'main' into aspect-ratio
root00198 Jan 11, 2020
36059eb
Merge branch 'aspect-ratio' of https://github.com/root00198/image-seq…
root00198 Jan 11, 2020
ec87e47
Compatiable with Experimental GIF Manipulation
root00198 Jan 11, 2020
b8cc146
some refactoring
root00198 Jan 11, 2020
ffb3fa9
Merge branch 'main' into aspect-ratio
harshkhandeparkar Jan 12, 2020
7cc3058
Changed the name from aspect-ratio to Constrained Crop
root00198 Jan 12, 2020
80db847
Merge branch 'aspect-ratio' of https://github.com/root00198/image-seq…
root00198 Jan 12, 2020
807239b
cleanup
root00198 Jan 12, 2020
9728528
Changes requested
root00198 Jan 12, 2020
ae40c82
Added test module
root00198 Jan 12, 2020
c9c870e
Merge branch 'main' into aspect-ratio
root00198 Jan 14, 2020
57e455e
Merge branch 'main' into aspect-ratio
root00198 Jan 16, 2020
c46df41
Merge branch 'main' into aspect-ratio
jywarren Jan 16, 2020
b021060
Merge branch 'main' into aspect-ratio
root00198 Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/modules/ConstrainedCrop/Module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Crops an Image on the basic of the aspect ratio
* Crops an Image on the basic of the ratio provided
root00198 marked this conversation as resolved.
Show resolved Hide resolved
*/
module.exports = function ConstrainedCrop(options, UI) {

Expand All @@ -11,9 +11,9 @@ module.exports = function ConstrainedCrop(options, UI) {
var step = this,
startingX = Number(options.startingX || defaults.startingX),
startingY = Number(options.startingY || defaults.startingY),
aspectRatio = (options.aspectRatio || defaults.aspectRatio).split(':'),
widthRatio = Number(aspectRatio[0]),
heightRatio = Number(aspectRatio[1]);
constrainedRatio = (options.constrainedRatio || defaults.constrainedRatio).split(':'),
root00198 marked this conversation as resolved.
Show resolved Hide resolved
widthRatio = Number(constrainedRatio[0]),
heightRatio = Number(constrainedRatio[1]);

function extraManipulation(pixels) {
var width = pixels.shape[0],
Expand Down
2 changes: 1 addition & 1 deletion src/modules/ConstrainedCrop/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"desc": "Y-position (measured from top) from where cropping starts",
"default": 0
},
"aspectRatio":{
"constrainedRatio":{
"type": "string",
"desc": "Enter aspect ratio in following format width:height",
"default": "1:1"
Expand Down