Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Typo Error Corrected #1278

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Small Typo Error Corrected #1278

merged 2 commits into from
Oct 29, 2019

Conversation

vaibhavmatta
Copy link

@vaibhavmatta vaibhavmatta commented Oct 20, 2019

Fixes #1277

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@vaibhavmatta
Copy link
Author

@publiclab/is-reviewers
There was only one typing mistake which I wanted to be correct in README.md file. I think this can be merged without any hesitation . Thanks : 😊

@codecov
Copy link

codecov bot commented Oct 20, 2019

Codecov Report

Merging #1278 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1278   +/-   ##
=======================================
  Coverage   32.26%   32.26%           
=======================================
  Files         107      107           
  Lines        1971     1971           
  Branches      292      292           
=======================================
  Hits          636      636           
  Misses       1335     1335

@jywarren jywarren merged commit cff82c9 into publiclab:main Oct 29, 2019
@welcome
Copy link

welcome bot commented Oct 29, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find typing errors in Readme file
3 participants