Fixes:grid-overlay for negetive input and 0 #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashna27
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1205 +/- ##
=======================================
Coverage 55.11% 55.11%
=======================================
Files 117 117
Lines 2344 2344
Branches 360 360
=======================================
Hits 1292 1292
Misses 1052 1052 |
|
This looks good - is it ready to merge? Thank you! |
jywarren
approved these changes
Aug 19, 2019
|
Merged! Thank you! |
jywarren
pushed a commit
that referenced
this pull request
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1203
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test@publiclab/is-reviewersfor help, in a comment below0 value is now mapped to 1 as the || operator makes it to 100 and also using 0 will lead to an infinite loop. Also now negetive values will also not lead to infinite loop.