Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in info.json #408

Closed
5 tasks
aashna27 opened this issue Oct 14, 2018 · 5 comments
Closed
5 tasks

Typo in info.json #408

aashna27 opened this issue Oct 14, 2018 · 5 comments

Comments

@aashna27
Copy link

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file info.json by navigating to "\src\modules\FisheyeGl\info.json" and edit the lines as shown below.

See this page for some help in taking your first steps!

  1. Go to lines 57 and 62:
      "desc": "Patht to a WebGL fragment shader file",

      "desc": "Patht to a WebGL vertex shader file",
  1. Then change them as:
      "desc": "Path to a WebGL fragment shader file",

      "desc": "Path to a WebGL vertex shader file",

And you are done !!! 👍

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@gitmate
Copy link

gitmate bot commented Oct 14, 2018

GitMate.io thinks the contributor most likely able to help you is @GitMate[bot].

Possibly related issues are #209 (Module info in demo should source from info.json), #401 (Typo in CONTRIBUTING.MD), #407 (Remove Redundant text and Capitalize first word), #390 (Fix alignment of image sequencer description), and #378 (add a website icon to the website link).

1 similar comment
@gitmate
Copy link

gitmate bot commented Oct 14, 2018

GitMate.io thinks the contributor most likely able to help you is @GitMate[bot].

Possibly related issues are #209 (Module info in demo should source from info.json), #401 (Typo in CONTRIBUTING.MD), #407 (Remove Redundant text and Capitalize first word), #390 (Fix alignment of image sequencer description), and #378 (add a website icon to the website link).

@sagarwala
Copy link

Hi, I would like to work on this issue. It looks like it is in Open State. Has anyone already opened a pull request or worked on this?

sagarwala added a commit to sagarwala/image-sequencer that referenced this issue Oct 14, 2018
ikshitiz added a commit to ikshitiz/image-sequencer that referenced this issue Oct 14, 2018
This commit fixes the issue publiclab#408
This was referenced Oct 14, 2018
@Divy123
Copy link
Member

Divy123 commented Oct 17, 2018

Hi! Is this issue still open to contribute?

@tech4GT
Copy link
Member

tech4GT commented Oct 18, 2018

@Divy123 I think this one was fixed already, we could use your help on another one. Thanks! 😄

@tech4GT tech4GT closed this as completed Oct 18, 2018
jywarren pushed a commit that referenced this issue Oct 19, 2018
* fix typos

This commit fixes the issue #408

* remove trailing space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants