detect edges stalling or broken?

[jywarren]

https://publiclab.github.io/image-sequencer/examples/#steps=edge-detect{blur:2|highThresholdRatio:0.2|lowThresholdRatio:0.15}

Even on a reasonably powerful machine this seems to hang with the example image. @tech4GT any ideas? It shouldn't be this power-hungry, right?

[gitmate]

GitMate.io thinks the contributor most likely able to help you is @tech4GT.

Possibly related issues are #176 (Add option to export edge-detected image with black background), #166 (Edge detection module), #118 (Assorted improvements to be broken into separate issues), #33 (pr #30 broke Travis build?), and #165 (Various module ideas to be broken out into separate issues).

[gitmate]

GitMate.io thinks the contributor most likely able to help you is @tech4GT.

Possibly related issues are #176 (Add option to export edge-detected image with black background), #166 (Edge detection module), #118 (Assorted improvements to be broken into separate issues), #33 (pr #30 broke Travis build?), and #165 (Various module ideas to be broken out into separate issues).

[tech4GT]

@jywarren hmm let me see what I can do with this, this module does need some refactoring since we now have meta modules we can maybe move blur out of this

[jywarren]

ah cool!

…

On Tue, Aug 28, 2018 at 11:44 AM Varun Gupta ***@***.***> wrote: @jywarren <https://github.com/jywarren> hmm let me see what I can do with this, this module does need some refactoring since we now have meta modules we can maybe move blur out of this — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#323 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJw24QcdxQGIhhW8NsAr3EjHBhoI5ks5uVWVUgaJpZM4WP3rL> .

[tech4GT]

My laptop broke down, currently trying to setup my dev-environment on an old windows laptop while my mac is repaired, hopefully will be able to look into this today.

[tech4GT]

Hmm @jywarren i think I have found the problem, there is a little issue with the hysteresis step, so I am going to fix that, plus I think should we move this into a metamodule, the workflow will look like this grayscale,blur,sobel,double-threshold,connected-component-labelling,hysteresis or should we keep this as one module only?

[tech4GT]

I think that would depend on if we want to use this in other meta-modules, since the current implementation does not support meta-module inside of a meta-module.

[jywarren]

aha, well, interesting. Will the truly isolated meta modules support nested meta modules? Then if so maybe we refactor this as a meta module AFTER that work?

…

On Tue, Sep 4, 2018 at 11:52 AM Varun Gupta ***@***.***> wrote: I think that would depend on if we want to use this in other meta-modules, since the current implementation does not support meta-module inside of a meta-module. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#323 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ9eNDnUA0WUNksNBYLHjinlZ0Yd7ks5uXqGWgaJpZM4WP3rL> .

[tech4GT]

Yeah totally! We can keep this as a long term issue. I'll make the issue right now.

[jywarren]

super!

…

On Tue, Sep 4, 2018 at 12:57 PM Varun Gupta ***@***.***> wrote: Yeah totally! We can keep this as a long term issue. I'll make the issue right now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#323 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ273KzmnMvYG3YejuFaGTCWZlwOIks5uXrDYgaJpZM4WP3rL> .