Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable/dim the Add step button until a module is selected #303

Closed
tech4GT opened this issue Jul 16, 2018 · 14 comments
Closed

Disable/dim the Add step button until a module is selected #303

tech4GT opened this issue Jul 16, 2018 · 14 comments

Comments

@tech4GT
Copy link
Member

tech4GT commented Jul 16, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Issue:
We need to disable the Add Step button which is used to add steps until a step has been selected from dropdown. ie The button should not be clickable till none option is selected.

We can use the same kinds of selectors to modify it, add more text, change the styling -- using Bootstrap styles:

https://getbootstrap.com/docs/3.3/css/

@gitmate
Copy link

gitmate bot commented Jul 16, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #302 (Disable/dim the Save button until step inputs have been changed), #269 (Prior steps need not re-run when a new module is added or deleted), #158 (Add a Saturation Module), #27 (add fisheyegl module), and #138 (Add a Dithering module).

1 similar comment
@gitmate
Copy link

gitmate bot commented Jul 16, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #302 (Disable/dim the Save button until step inputs have been changed), #269 (Prior steps need not re-run when a new module is added or deleted), #158 (Add a Saturation Module), #27 (add fisheyegl module), and #138 (Add a Dithering module).

@coderjolly
Copy link
Member

can u attach an image for visual representation ?

@tech4GT
Copy link
Member Author

tech4GT commented Jul 17, 2018

hi @coderjolly Welcome to the community😁

@tech4GT
Copy link
Member Author

tech4GT commented Jul 17, 2018

screen shot 2018-07-17 at 4 59 18 pm

Here, since I have not selected any step the button should be disabled

@tech4GT
Copy link
Member Author

tech4GT commented Jul 17, 2018

<button class="btn btn-success btn-lg" name="add">Add Step</button>

We have made the button here

@jywarren
Copy link
Member

jywarren commented Jul 17, 2018 via email

@LostLaser
Copy link

I'm not sure if anyone is working on this at the moment, but do you mind if I take a shot?

@tech4GT
Copy link
Member Author

tech4GT commented Jul 17, 2018

Go ahead!! Thanks

@kevinkmmak
Copy link

I am a first-timer. I have forked and cloned the repo.
Am I supposed to add scripts inside examples/index.html, or add to demo.js?
I think I will control the attribute "disabled" by using prop method.

@tech4GT
Copy link
Member Author

tech4GT commented Jul 20, 2018

You can do it in either but we prefer to do it in demo.js

@ebinxavier
Copy link

ebinxavier commented Jul 20, 2018

I have raised a PR : #311 for this issue. please check.

@jywarren
Copy link
Member

Is this complete in #310? Thanks, everyone!

@tech4GT
Copy link
Member Author

tech4GT commented Jul 25, 2018

Yes @jywarren !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants