Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various demo UI fixes - checklist #232

Closed
4 tasks done
jywarren opened this issue May 1, 2018 · 5 comments
Closed
4 tasks done

Various demo UI fixes - checklist #232

jywarren opened this issue May 1, 2018 · 5 comments

Comments

@jywarren
Copy link
Member

jywarren commented May 1, 2018

Small but helpful list of tweaks we could break out into first-timers-only issues! (once the demo refactor is done (#214)

  • Disable/dim the Save button until step inputs have been changed
  • Disable/dim the Add step button until a module is selected
  • Show a Press save to see changes next to each step's Save button
  • Add a download button at the bottom, in a panel next to the Add Step button
@jywarren
Copy link
Member Author

Here's where the Save button is made:

$(step.ui.querySelector("div.details")).append(
"<p><button class='btn btn-default btn-save'>Save</button></p>"
);

We can use the same kinds of selectors to modify it, add more text, change the styling -- using Bootstrap styles:

https://getbootstrap.com/docs/3.3/css/

@tech4GT
Copy link
Member

tech4GT commented Jul 16, 2018

Breaking these up to make some first timer issues!!

@jywarren
Copy link
Member Author

jywarren commented Jul 17, 2018 via email

@Mridul97
Copy link

Hello, I made changes to show 'Press save to see changes' next to each step's 'Save' button and add a 'download' button next to the 'Add Step' button. Please take a look. Pull request #325.

@tech4GT
Copy link
Member

tech4GT commented Sep 25, 2018

I think this issue is done, closing this up now!

@tech4GT tech4GT closed this as completed Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants