replaceImage() returns error

[jywarren]

I see an error on running:

sequencer.replaceImage('img', 'invert');

in the console on the demo

The error is at addSteps() on this line, which by the way maybe should be broken into multiple lines for readability:

      this_.loadImage('default',url).addSteps('default',steps).run(function(out){

https://github.com/publiclab/image-sequencer/blob/master/src/ReplaceImage.js#L28

I think this is because in loadImage() we don't return this and so it's not chainable. That's on this line:

Should return this go here? -- https://github.com/publiclab/image-sequencer/blob/master/src/LoadImage.js#L100

We should solve this but also add tests for:

• if this method and others are chainable
• if replaceImage() works (this should be testable, no?)

Thanks!

[jywarren]

The contributors most likely able to help are:

@jywarren
@ccpandhare

[jywarren]

@ccpandhare if you have a chance to try a fix for this, much appreciated! I tried a couple things and didn't make a lot of progress :-/

[ccpandhare]

Sure will do that!

…

On Tue, Oct 24, 2017, 08:43 Jeffrey Warren ***@***.***> wrote: @ccpandhare <https://github.com/ccpandhare> if you have a chance to try a fix for this, much appreciated! I tried a couple things and didn't make a lot of progress :-/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#147 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AT0xnF0qvxIRxkveUAYFZBjZSQubcITMks5svVXbgaJpZM4P_wg_> .

[ccpandhare]

Sorry, this was a mistake on my part.
Fixed the other things, but I don't think replaceImage is meant to be chainable (it isnt).