Refactor the codebase

[Rishabh570]

Fixes #201
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[Rishabh570]

@jywarren @sagarpreet-chadha @harshithpabbati I've opened this PR for #201, please take a look.

Sorry, I've made a single commit for all of it, I can break it down into smaller commits if you want...

Here is my gh-pages link for current changes: http://rishabh570.me/community-toolbox/

[jywarren]

Oh wow! Huge!

So, this is awesome. I did get some kind of error here, though - can you take a look?

Great work!!!

[Rishabh570]

@jywarren Hmm, I'm not facing this error, I guess hard refreshing the page would resolve this error...I'll take a look.
Thanks 😃

[Rishabh570]

or maybe disabling the browser cache from network tab...

[Rishabh570]

Hi @jywarren, I've made a GIF of how these changes work in my local version of the site...I don't know why gh-pages is not reflecting the latest changes. Please take a look,

[Rishabh570]

Pinging @jywarren @publiclab/reviewers, please take a look :)

[rexagod]

@Rishabh570 Can you verify if your promises are getting resolved properly? Skimming through the errors this seems to be an async issue.

[Rishabh570]

@rexagod yeah so the errors showing up on @jywarren 's screenshot were related to database setting up...actually if we try to do any kind of db operation while db is setting up (it takes some time to set-up, some milliseconds) that error gets showed up. But that's not from my current changes as I've shared a screenshot above that doesn't contain those errors...

[Rishabh570]

But don't know why gh-pages are not reflecting that...

[rexagod]

actually if we try to do any kind of db operation while db is setting up (it takes some time to set-up, some milliseconds) that error gets showed up

Did you set up some sort of async wrapper to handle this? If no, consider wrapping this in a async/await function, or maybe return a promise even. But if you have done something like this, I guess you should increase the timeouts (not recommended).

Also, is this live? I can provide more input on taking a closer look.

[Rishabh570]

@rexagod Yes, so it returns a promise ( there are promises for every async process ).

Yeah, my changes are live at http://rishabh570.me/community-toolbox/

[rexagod]

Hey @Rishabh570, sorry I got a little busy over at ldi and forgot about this. Taking a look now!

[rexagod]

@Rishabh570 I guess you should try resolving the promise before passing it down the chain, like this,

return fetch(`https://api.github.com/repos/${org}/${repo}/commits?since=${queryTime}`)
// add this =========              
  .then(function(res) {
                  if(response.status === "200") {
                    return Promise.resolve(res);
                  }
                })
// ===============
                .then(function gotResponse(response) {
                        return response.json();
                })

Let me know if this fixes it!

[Rishabh570]

@rexagod @jywarren Please visit http://rishabh570.me/community-toolbox/ . Now it's working fine...Here's the GIF,

[ I re-pushed it to my gh-pages ]

[Rishabh570]

Done with some final little changes regarding the recent contribs utility file name change...It's ready now I think...

[jywarren]

Yes it works well! And it's fast! I'll merge this now, great work! Would you like merge rights to publiclab gh-pages or do you have that already?

[Rishabh570]

@jywarren No, I don't have those rights to PL's gh-pages currently...

[jywarren]

Are you sure? I think you have write permissions for the project.

[Rishabh570]

I was a little confused actually...am I supposed to update publiclab/community-toolbox's gh-pages?

[jywarren]

If you're comfortable doing so, please do! It is a merge commit because the node modules have been added to that branch.

…

On Wed, Jun 5, 2019, 7:06 PM Rishabh Rawat ***@***.***> wrote: I was a little confused actually...am I supposed to update publiclab/community-toolbox's gh-pages? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#213?email_source=notifications&email_token=AAAF6JZ7YWVU4L32KCRD7R3PZBWJBA5CNFSM4HQMAL72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBQOPI#issuecomment-499320637>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J4A7OLCOIDLVMNJK7LPZBWJBANCNFSM4HQMAL7Q> .

[Rishabh570]

I've never done it before but I would love to try that... So basically PL's main will be merged with gh-pages and gh-pages will have a merge commit, right?

[jywarren]

Yes, that's right!

…

On Thu, Jun 6, 2019, 3:37 AM Rishabh Rawat ***@***.***> wrote: I've never done it before but I would love to try that... So basically PL's main will be merged with gh-pages and gh-pages will have a mere commit, right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#213?email_source=notifications&email_token=AAAF6JZSPKYANDYHW5WOJR3PZDSFXA5CNFSM4HQMAL72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXCOHLI#issuecomment-499442605>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J56TQARZNHB7BZLLPTPZDSFXANCNFSM4HQMAL7Q> .