Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refined custom insert dropdown UI fixes #816 #817

Merged
merged 3 commits into from
Feb 1, 2022
Merged

refined custom insert dropdown UI fixes #816 #817

merged 3 commits into from
Feb 1, 2022

Conversation

NARUDESIGNS
Copy link
Collaborator

@NARUDESIGNS NARUDESIGNS commented Jan 31, 2022 •
edited
Loading

Refined the custom insert UI by:

  • adding hover effect
  • adding necessary padding and margin as well
  • adding cursor pointer

Here's what it looks like currently

Screenshot 2022-01-31 at 3 37 37 PM

Here's what the fix looks like

Screenshot 2022-01-31 at 3 37 17 PM

@jywarren @TildaDares please have a look

@gitpod-io
Copy link

gitpod-io bot commented Jan 31, 2022

TildaDares
TildaDares approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @NARUDESIGNS

govindgoel
govindgoel approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@govindgoel govindgoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NARUDESIGNS NARUDESIGNS mentioned this pull request Jan 31, 2022
Open
31 tasks
jywarren
jywarren approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice. Thank you!!

@jywarren jywarren merged commit 114c0f1 into main Feb 1, 2022
@NARUDESIGNS
Copy link
Collaborator Author

Thank you too! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TildaDares TildaDares TildaDares approved these changes

@govindgoel govindgoel govindgoel approved these changes

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NARUDESIGNS @jywarren @govindgoel @TildaDares