Table popup hide on click on page and everything except table button … #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TildaDares
requested changes
Jan 21, 2022
…and its children fixes publiclab#750
…and its children fixes publiclab#750
|
Hey @NARUDESIGNS @TildaDares, Can you please review this PR |
|
Hey, @RaviAnand111 trust you are well. |
31 tasks
|
yeah, @NARUDESIGNS thanks for reminding, I will move that function inside and make a commit, |
…on and its children fixes publiclab#750
TildaDares
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Amazing collaboration @RaviAnand111 and @NARUDESIGNS. Great job!
|
Hi @RaviAnand111 and @NARUDESIGNS, I think it'll be better to keep all discussions about this issue/PR in the same place so that it's a lot easier to keep up with the changes. Thank you! |
TildaDares
reviewed
Jan 26, 2022
…on and its children fixes publiclab#750
… into fix-multiple-popover-table-popover
|
🎉 |
|
Thanks alot @jywarren |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes table button part at #750
follow up of #793
Can you please review this @NARUDESIGNS @TildaDares @jywarren
ThankYou