-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add polygon to searched country/state #1258
base: main
Are you sure you want to change the base?
Add polygon to searched country/state #1258
Conversation
Thanks for opening this pull request! |
Hi @vanithaak , here is my changes for issue #1250. |
Wow, this looks really good! @vanithaak i was thinking, what if we made the polygon disappear after a few seconds? That way it doesn't interfere with your editing activities. Could we amend this with a @liryyy great work here. You've done it just right, it seems. Can you upload a screencast video so we can confirm? Thanks! |
Great idea! I'll see what we can do. Thanks Jeff |
@jywarren Thank you for your suggestion. Here is the video about the change that I made for this issue. Leaflet.DistortableImage.Example.-.12.November.2022.mp4 |
Hi @liryyy, thank you for the video. As Jeff mentioned, he would like us to add |
@liryyy Hey, I am a enthusiastic newcomer and I would love to contribute. Could you please guide me through the same? |
Fixes #1250 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!