changed some variable declarations in Leaflet.DistortableImage/src/components/DistortableImage.Keymapper.js

[jesutobi]

@TildaDares I have fixed the issues in ..... Fixes #1086
https://github.com/publiclab/Leaflet.DistortableImage/issues/1086.

in this directory Leaflet.DistortableImage/src/components/DistortableImage.Keymapper.js
I changed the variable declaration on line 42 from "var" to const
I changed the variable declaration on line 45 from "var" to let
I changed the variable declaration on line 52 from "var" to const
I changed the variable declaration on line 66 from "var" to const
I changed the variable declaration on line 131 from "var" to const

[welcome]

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

[gitpod-io]

[PeculiarE]

Hi @jesutobi....thank you for working on this. Could you please undo the changes in the leaflet.distortableimage.js file. Only the DistortableImage.Keymapper.js file should be changed. Thank you!

[jesutobi]

@PeculiarE i would do that right now,thanks, but i dont know how that happened becasue i only focused on leaflet.distortableimage.js...do i need to create a new pull request?

[jesutobi]

@PeculiarE i have done it as you requested

[PeculiarE]

Hi @jesutobi....please accept and commit the suggested change by clicking on the Commit suggestion button in the review above.

Once this is done, your PR will be ready to merge.

Thank you, and great work so far!

[jesutobi]

@PeculiarE thank you, i have added the suggested change

[PeculiarE]

Thank you @jesutobi...but the build is failing due to indentation issues. An extra space was omitted in the initial commit.

So, once again, please accept and commit the suggested change by clicking on the Commit suggestion button in the review above, and then we can merge 😄

[jesutobi]

@PeculiarE thank you, i am sorry for the many bugs 😥, i just commited the suggested changes

[PeculiarE]

It's okay @jesutobi....thanks for sticking with it ❤️

[jesutobi]

@PeculiarE, i still see the "merging is blocked" is there something else i didnt take note off ?

[PeculiarE]

Well done once again! @jesutobi

@TildaDares ....this is ready to merge. Thank you!

[PeculiarE]

@PeculiarE, i still see the "merging is blocked" is there something else i didnt take note off ?

Oh, don't worry about it. Merging can only be done by those with the appropriate repo permissions

[jesutobi]

It's okay @jesutobi....thanks for sticking with it ❤️

thanks you

[jesutobi]

It's okay @jesutobi....thanks for sticking with it ❤️

thanks you

[jesutobi]

@PeculiarE, i still see the "merging is blocked" is there something else i didnt take note off ?

Oh, don't worry about it. Merging can only be done by those with the appropriate repo permissions

okay

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

[TildaDares]

Congratulations on merging your PR @jesutobi 🎉

[TildaDares]

Thank you for the reviews @PeculiarE!

[7malikk]

Congratulations @jesutobi 🎊

[jesutobi]

Congratulations on merging your PR @jesutobi 🎉

thank you :)

[jesutobi]

Congratulations @jesutobi 🎊

thanks