Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update first time issue template #1122

Merged
merged 6 commits into from
Oct 12, 2022
Merged

update first time issue template #1122

merged 6 commits into from
Oct 12, 2022

Conversation

leilayesufu
Copy link
Contributor

Hi everyone, i tried creating a first time issue after solving mine, on going to the issue templates in the screenshot below, i discovered that there was no template for first time issues, on further inspection i discovered the first time issue template was present in the Leaflet.DistortableImage/.github as opposed to the Leaflet.DistortableImage/.github/ISSUE_TEMPLATE/ so i moved the file to the right folder
image

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Oct 11, 2022

@leilayesufu
Copy link
Contributor Author

@TildaDares @jywarren
Please kindly review

@TildaDares
Copy link
Member

Hi @leilayesufu, instead of renaming the files, maybe we could create a file with the FTO template in the ISSUE_TEMPLATE folder. Thanks!

@leilayesufu
Copy link
Contributor Author

Hi, @TildaDares
Yes, that’s exactly what I did

@TildaDares
Copy link
Member

Hi @leilayesufu, you deleted a file in e5e1cb1

@leilayesufu
Copy link
Contributor Author

Hii, @TildaDares
Yes,
I deleted the old template that was in the wrong folder and created a new one in the right folder that’s the issues template folder with the exact same content

@TildaDares
Copy link
Member

@leilayesufu You don’t have to delete that file. Please revert the change. Thank you!

@leilayesufu
Copy link
Contributor Author

Oh, alright
Do I close this pull request and do that and create a new one?

@TildaDares
Copy link
Member

You should be able to revert a commit without having to close the PR.

Reverted the one I deleted
@leilayesufu
Copy link
Contributor Author

I have created the file back
Please kindly review

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @leilayesufu. Thank you!

@TildaDares TildaDares merged commit c5e75f8 into publiclab:main Oct 12, 2022
@leilayesufu
Copy link
Contributor Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants