-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RotateAction.js #1087
Update RotateAction.js #1087
Conversation
Changed var edit to let edit. I chose let over const because of the variable name edit - as this connotes changes is expected.
Thanks for opening this pull request! |
Hello, thank you for your contribution, what issue is this for, can you please link to it? Are you sure someone else has not already claimed it? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @titiodus, feel free to just click the Commit Suggestion
button. Thank you!
I changed var to let. Co-authored-by: Tilda Udufo <[email protected]>
@TildaDares I have done so. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @titiodus. Thank you!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Congratulations on merging your PR @titiodus 🎉 |
Thank you @TildaDares. I am willing to do more. I can coordinate contributors and such. I am alao available to handle any other issues. |
Changed var edit to let edit. I chose let over const because of the variable name edit - as this connotes changes is expected.
Hope my PR is accepted and merged.
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!