Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide clear button in single-select #7430

Open
wants to merge 3 commits into
base: release/2
Choose a base branch
from

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented Feb 28, 2025

Refs: #7405

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

Copy link
Contributor

github-actions bot commented Feb 28, 2025

@@ -245,7 +245,7 @@ export class KolSingleSelect implements SingleSelectAPI {
}}
placeholder={this.state._placeholder}
/>
{this._inputValue && (
{this._inputValue && !this._hideClearButton && (
Copy link
Contributor

@laske185 laske185 Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Über den State gehen.

Suggested change
{this._inputValue && !this._hideClearButton && (
{this._inputValue && !this.state._hideClearButton && (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single-Select mit optionalen Löschen-Button
2 participants