Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve _value type for single select: Allow arbitrary values #7429

Open
wants to merge 2 commits into
base: release/2
Choose a base branch
from
Open

Improve _value type for single select: Allow arbitrary values #7429

wants to merge 2 commits into from

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Feb 28, 2025 •
edited
Loading

Refs: #7387

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@github-actions GitHub Actions
Copy link
Contributor

Netlify Draft Deployment
URL: https://67c1998d51356f1f2517f117--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/67c1998d51356f1f2517f117

@sdvg sdvg linked an issue Feb 28, 2025 that may be closed by this pull request
Type-Fehler beim _value-Property des Single-Select. #7387
Open
@sdvg sdvg marked this pull request as ready for review February 28, 2025 11:36
@sdvg sdvg added the v2 label Feb 28, 2025
laske185
laske185 requested changes Mar 3, 2025
View reviewed changes
packages/components/src/components/single-select/controller.ts
public validateValue(value?: string): void {
watchString(this.component, '_value', value);
public validateValue(value?: StencilUnknown): void {
watchValidator(this.component, '_value', Boolean, new Set([`StencilUnknown`]), value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
watchValidator(this.component, '_value', Boolean, new Set([`StencilUnknown`]), value);
watchValidator(this.component, '_value', v => v !== undefined, new Set([`StencilUnknown`]), value);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laske185 laske185 laske185 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type-Fehler beim _value-Property des Single-Select.
2 participants
@sdvg @laske185